Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Applicants to Withdraw a submission #3296

Open
frankduncan opened this issue Mar 21, 2023 · 0 comments · May be fixed by #3298
Open

Allow Applicants to Withdraw a submission #3296

frankduncan opened this issue Mar 21, 2023 · 0 comments · May be fixed by #3298
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).

Comments

@frankduncan
Copy link
Contributor

Describe the solution you'd like

A new workflow and UX to allow applicants to move to a new withdrawn status. This is for applicants who no longer want to apply, after submitting.

Describe alternatives you've considered

This was seen as a better system than having the applicant reach out and with one of the admin team deleting the submission

Additional context

After discussion about this feature, a config toggle should also be added to allow admins of hypha to opt in or out of this feature (set to False initially)

Priority

This was originally a high priority, but it was merged into our fork. So a PR will be incoming

Affected roles

  • Applicants
@frankduncan frankduncan added the Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). label Mar 21, 2023
@frankduncan frankduncan mentioned this issue Mar 23, 2023
Closed
frankduncan pushed a commit that referenced this issue Mar 23, 2023
@chriszs
feat: add submission withdrawal
9faa366 
Closes #3296
frankduncan pushed a commit that referenced this issue Mar 23, 2023
@chriszs
feat: add submission withdrawal
d8eb86c 
Closes #3296
@frankduncan frankduncan linked a pull request Mar 23, 2023 that will close this issue
Open
frankduncan pushed a commit that referenced this issue Apr 15, 2023
@chriszs
feat: add submission withdrawal
397cf78 
Closes #3296
frjo pushed a commit that referenced this issue Jul 26, 2023
@chriszs @frjo
feat: add submission withdrawal
f2b0069 
Closes #3296
frjo added a commit that referenced this issue Jul 26, 2023
@frjo
Merge branch 'enhancement/gh-3296-add-withdraw' into test
7ab6984
frjo added a commit that referenced this issue Sep 1, 2023
@frjo
Merge remote-tracking branch 'origin/enhancement/gh-3296-add-withdraw…
bddbd40 
…' into test
frjo added a commit that referenced this issue Sep 7, 2023
@frjo
Merge remote-tracking branch 'origin/enhancement/gh-3296-add-withdraw…
a7c5e12 
…' into test
@fourthletter fourthletter modified the milestone: Backlog Sep 22, 2023
bickelj pushed a commit that referenced this issue Jul 23, 2024
@frankduncan @bickelj
Add "withdrawn" to list of inactive statuses
358ac25 
This affected different calculating pages, like the open round
percentage completions.

Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@chriszs @bickelj
feat: add submission withdrawal
e278571 
Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@bickelj
fix: remove refs to dismiss while adding withdrawn
0d43bae 
Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@bickelj
Add ENABLE_SUBMISSION_WITHDRAWAL to allow enabling withdrawals
1563478 
This only affects about enabling them, not whether they are in the
system.  That means that if the configuration is changed over the
lifetime of a system, things that were withdrawn when it was enabled
retain that status.

Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@bickelj
Change permissions to withdraw to just being an applicant
d9c8164 
Based on Review in #3298, the decision was made that an applicant can
withdraw at any time, without edit permissions, and edit permissions
should not be to applicants for their own submissions.

Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@bickelj
Add withdraw to all workflows, move to end of workflow
f57448c 
This creates a single withdrawn status for each workflow, living at the
end (next to accepted/rejected), and adds transistions for all the
different workflow types.

Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@frjo @bickelj
Move css from custom file.
32fbdd9 
Issue #3296
bickelj pushed a commit that referenced this issue Jul 24, 2024
@frankduncan @bickelj
Add "withdrawn" to list of inactive statuses
307ddd4 
This affected different calculating pages, like the open round
percentage completions.

Issue #3296
bickelj added a commit that referenced this issue Jul 24, 2024
@bickelj
Clean up from cherry-pick/rebase
ded4ba5 
Removed a redeclared variable and reformatted.

Issue #3296
bickelj added a commit that referenced this issue Jul 24, 2024
@bickelj
Clean up from cherry-pick/rebase
a3cdaf0 
Removed a redeclared variable and reformatted.

Issue #3296
bickelj added a commit that referenced this issue Jul 24, 2024
@bickelj
Clean up from cherry-pick/rebase
cacfc93 
Removed a redeclared variable and reformatted.

Issue #3296
bickelj pushed a commit that referenced this issue Jul 25, 2024
@frankduncan @bickelj
Fix error in all submissions table
4e8f2bd 
Withdrawn status needs to be added to a mapping, apparently :)

Issue #3296
bickelj added a commit that referenced this issue Jul 25, 2024
@bickelj
Clean up from cherry-pick/rebase
8d03e12 
Removed a redeclared variable and reformatted.

Issue #3296
bickelj added a commit that referenced this issue Jul 25, 2024
@bickelj
Distinguish withdrawal permissions
f4ae001 
Add distinct withdrawal permissions within stages of workflows. By
default, let the applicant withdraw at any stage. On the submission
page, display the Withdraw button assuming the setting
`ENABLE_SUBMISSION_WITHDRAWAL` is true and the withdrawal permissions
are met.

Issue #3296
bickelj added a commit that referenced this issue Jul 25, 2024
@bickelj
Make "Withdraw" button more consistent with others
f63f0b2 
Add a heroicon to "Withdraw" button and style it similar to "Delete".

Issue #3296
bickelj added a commit to bickelj/hypha that referenced this issue Jul 30, 2024
@bickelj
Improve withdrawal permissions and error handling
5b656bb 
The permissions on the `*withdraw` items should be `no_permissions`.
After a submission is withdrawn, nothing further should happen to it.

When `perform_transition` is called in the View, that function will
already check for valid transitions and raise an exception if needed.
So do not bother looking into the transitions, instead look directly
for the withdraw action. And expect exactly one of those, otherwise
raise an exception with details of expectations.

Issue HyphaApp#3296
frjo pushed a commit that referenced this issue Aug 7, 2024
@chriszs @frjo
feat: add submission withdrawal
06c1a3e 
Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@frankduncan @frjo
Add "withdrawn" to list of inactive statuses
ab91e39 
This affected different calculating pages, like the open round
percentage completions.

Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@frankduncan @frjo
Fix error in all submissions table
3d7e1c9 
Withdrawn status needs to be added to a mapping, apparently :)

Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@bickelj @frjo
Clean up from cherry-pick/rebase
8fb9410 
Removed a redeclared variable and reformatted.

Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@bickelj @frjo
Distinguish withdrawal permissions
3601388 
Add distinct withdrawal permissions within stages of workflows. By
default, let the applicant withdraw at any stage. On the submission
page, display the Withdraw button assuming the setting
`ENABLE_SUBMISSION_WITHDRAWAL` is true and the withdrawal permissions
are met.

Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@bickelj @frjo
Make "Withdraw" button more consistent with others
3807d53 
Add a heroicon to "Withdraw" button and style it similar to "Delete".

Issue #3296
frjo pushed a commit that referenced this issue Aug 8, 2024
@bickelj @frjo
Improve withdrawal permissions and error handling
13fc0ae 
The permissions on the `*withdraw` items should be `no_permissions`.
After a submission is withdrawn, nothing further should happen to it.

When `perform_transition` is called in the View, that function will
already check for valid transitions and raise an exception if needed.
So do not bother looking into the transitions, instead look directly
for the withdraw action. And expect exactly one of those, otherwise
raise an exception with details of expectations.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@chriszs @frjo
feat: add submission withdrawal
8a5e0d7 
Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frjo
fix: remove refs to dismiss while adding withdrawn
9838119 
Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frjo
Add ENABLE_SUBMISSION_WITHDRAWAL to allow enabling withdrawals
aed473b 
This only affects about enabling them, not whether they are in the
system.  That means that if the configuration is changed over the
lifetime of a system, things that were withdrawn when it was enabled
retain that status.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frjo
Change permissions to withdraw to just being an applicant
5e7c6a2 
Based on Review in #3298, the decision was made that an applicant can
withdraw at any time, without edit permissions, and edit permissions
should not be to applicants for their own submissions.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frjo
Add withdraw to all workflows, move to end of workflow
d7bcffb 
This creates a single withdrawn status for each workflow, living at the
end (next to accepted/rejected), and adds transistions for all the
different workflow types.

Issue #3296
frjo added a commit that referenced this issue Oct 9, 2024
@frjo
Move css from custom file.
a560bd2 
Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frankduncan @frjo
Add "withdrawn" to list of inactive statuses
0aaa2cc 
This affected different calculating pages, like the open round
percentage completions.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@frankduncan @frjo
Fix error in all submissions table
7629ec7 
Withdrawn status needs to be added to a mapping, apparently :)

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@bickelj @frjo
Clean up from cherry-pick/rebase
604e286 
Removed a redeclared variable and reformatted.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@bickelj @frjo
Distinguish withdrawal permissions
03696b5 
Add distinct withdrawal permissions within stages of workflows. By
default, let the applicant withdraw at any stage. On the submission
page, display the Withdraw button assuming the setting
`ENABLE_SUBMISSION_WITHDRAWAL` is true and the withdrawal permissions
are met.

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@bickelj @frjo
Make "Withdraw" button more consistent with others
c820869 
Add a heroicon to "Withdraw" button and style it similar to "Delete".

Issue #3296
frjo pushed a commit that referenced this issue Oct 9, 2024
@bickelj @frjo
Improve withdrawal permissions and error handling
68aaee6 
The permissions on the `*withdraw` items should be `no_permissions`.
After a submission is withdrawn, nothing further should happen to it.

When `perform_transition` is called in the View, that function will
already check for valid transitions and raise an exception if needed.
So do not bother looking into the transitions, instead look directly
for the withdraw action. And expect exactly one of those, otherwise
raise an exception with details of expectations.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@chriszs @frjo
feat: add submission withdrawal
a79d080 
Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frjo
fix: remove refs to dismiss while adding withdrawn
589e3c5 
Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frjo
Add ENABLE_SUBMISSION_WITHDRAWAL to allow enabling withdrawals
ed09ae9 
This only affects about enabling them, not whether they are in the
system.  That means that if the configuration is changed over the
lifetime of a system, things that were withdrawn when it was enabled
retain that status.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frjo
Change permissions to withdraw to just being an applicant
34618bc 
Based on Review in #3298, the decision was made that an applicant can
withdraw at any time, without edit permissions, and edit permissions
should not be to applicants for their own submissions.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frjo
Add withdraw to all workflows, move to end of workflow
9cf2caf 
This creates a single withdrawn status for each workflow, living at the
end (next to accepted/rejected), and adds transistions for all the
different workflow types.

Issue #3296
frjo added a commit that referenced this issue Oct 18, 2024
@frjo
Move css from custom file.
ace6616 
Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frankduncan @frjo
Add "withdrawn" to list of inactive statuses
2b54958 
This affected different calculating pages, like the open round
percentage completions.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@frankduncan @frjo
Fix error in all submissions table
f06e11c 
Withdrawn status needs to be added to a mapping, apparently :)

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@bickelj @frjo
Clean up from cherry-pick/rebase
e7598a9 
Removed a redeclared variable and reformatted.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@bickelj @frjo
Distinguish withdrawal permissions
8940f47 
Add distinct withdrawal permissions within stages of workflows. By
default, let the applicant withdraw at any stage. On the submission
page, display the Withdraw button assuming the setting
`ENABLE_SUBMISSION_WITHDRAWAL` is true and the withdrawal permissions
are met.

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@bickelj @frjo
Make "Withdraw" button more consistent with others
04ec033 
Add a heroicon to "Withdraw" button and style it similar to "Delete".

Issue #3296
frjo pushed a commit that referenced this issue Oct 18, 2024
@bickelj @frjo
Improve withdrawal permissions and error handling
79eb236 
The permissions on the `*withdraw` items should be `no_permissions`.
After a submission is withdrawn, nothing further should happen to it.

When `perform_transition` is called in the View, that function will
already check for valid transitions and raise an exception if needed.
So do not bother looking into the transitions, instead look directly
for the withdraw action. And expect exactly one of those, otherwise
raise an exception with details of expectations.

Issue #3296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
Public Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add submission withdrawal workflow HyphaApp/hypha
2 participants
@frankduncan @fourthletter