Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should workflow permissions be handled through wagtail interface #3297

Closed
frankduncan opened this issue Mar 23, 2023 · 1 comment
Closed

Comments

@frankduncan
Copy link
Contributor

While working on #3296, I realized that our withdrawing code relied on the applicant having edit permissions on the submission. This was not a result of changing the wagtail permissions for submissions to "edit", but rather on changing workflow.py here: https://github.com/HyphaApp/hypha/blob/main/hypha/apply/funds/workflow.py#L225

And changing it to applicant_edit_permissions. This seems like something that should be configured through the admin interface, rather than a code change, but I wanted to open up a discussion about the most appropriate place to enable this.

@fourthletter
Copy link
Contributor

I'm sorry we didn't get a chance to discuss this during our Tuesday morning call. We will make a point to discuss these items you've raised during upcoming meetings.

@fourthletter fourthletter modified the milestone: Backlog Sep 22, 2023
@frjo frjo closed this as completed Jul 5, 2024
@github-project-automation github-project-automation bot moved this to Launched in Public Roadmap Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Launched
Development

No branches or pull requests

3 participants