Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Topic cloud & fragment view #200

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft

FEATURE: Topic cloud & fragment view #200

wants to merge 2 commits into from

Conversation

arnaud9145
Copy link

@arnaud9145 arnaud9145 commented Jun 14, 2019 •
edited by sab91
Loading

Content

Implemented fragment and cloud view
@arnaud9145, @taher100, @sab91 and @GuillaumeGilles42 for implementation
@Double-Ramzi and @qdelcourte

Checklist

Please check that your pull request is correct:

  • Each commit:
    • corresponds to a contribution that should be notified to users,
    • does not generate new errors or warnings at compile or test time,
    • must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
  • The title of a commit should:
    • begin with a contribution type
      • FEATURE for a behaviour allowing a user to do something new,
      • FIX for a behaviour which has been changed in order to meet user’s expectations,
      • TEST when it concerns an acceptance test,
      • PROCESS for a change in the way the software is built, tested, deployed,
      • DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
    • be followed by a colon (:) with one space after and no space before,
    • be followed by a title (written in English) as short, as user-centered and as explicit as possible
      • If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
      • If it is a fix, the title must describe the intended behavior (with should).
    • ends with a reference to the corresponding ticket with the following syntax:
      • (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
      • (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
      • (see #xx) otherwise,
  • Each committed line is:
    • useful (it would not work if removed)
      • if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
    • related to this very contribution (feature, fix...),
    • in English (with the exception of Gherkin scenarios in French and resulting steps),
    • without any typo in variable, class or function names,
    • correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

@vl-gx vl-gx changed the title Final version group entretient Final version group entretien Jun 14, 2019
benel
benel requested changes Jun 14, 2019
View reviewed changes
features/images_appartient_rubrique.feature Outdated Show resolved Hide resolved
features/step_definitions/fragment.rb Outdated
@@ -0,0 +1,62 @@
require 'capybara/cucumber'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one step definition file per Web page.
Since there is no "fragment" page, this file should not exist.
Please move the needed steps (and only them) into existing files.

features/step_definitions/fragment.rb Outdated
expect(page).to have_selector('.Items .item', count: int)
end

Alors("l'item {string} est décrit par une date") do |item|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A date? Which one?
Please note that scenarios should include samples therefore steps should include parameters.

features/step_definitions/fragment.rb Outdated
expect(parent).to have_selector('.date')
end

Alors("l'item {string} est décrit par un auteur") do |item|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

features/step_definitions/images_appartient_rubrique.rb Outdated
Capybara.app_host = "http://localhost:3000"
Capybara.default_max_wait_time = 10

def getUUID2(itemName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reuse existing methods (and edit them if necessary).

src/components/App/App.jsx Outdated
import { BrowserRouter as Router, Route, Switch } from 'react-router-dom'
import Portfolio from '../Portfolio/Portfolio.jsx'
import Item from '../Item/Item.jsx'
import Outliner from '../Outliner/Outliner.jsx'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit lines if it is not part of the feature you are implementing (it would mess completely the "blame" feature, and moreover it makes edition conflicts more likely).

src/components/App/App.jsx Outdated
<Route path="/" component={Portfolio} />
<Route path='/item/:corpus/:item' component={Item} />
<Route path='/viewpoint/:id' component={Outliner} />
<Route path='/' component={Portfolio} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

src/components/App/App.jsx Outdated
</Switch>
</Router>
)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

src/components/App/App.jsx Outdated
}

export default App;
export default App
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

src/components/Authenticated/Authenticated.jsx Outdated

const SESSION_URI = conf.services[0] + '/_session';
const SESSION_URI = conf.services[0] + '/_session'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fed up. Please scan each diff line yourself. And check EVERY rule before requesting for a pull.

@arnaud9145 arnaud9145 force-pushed the final-version-p19 branch 2 times, most recently from da07949 to ebe7b6c Compare June 21, 2019 09:30
sabri.ben_miled and others added 2 commits June 21, 2019 19:13
@GuillaumeGilles42
FEATURE: Add cloud and fragment view (see Hypertopic#48 and Hypertopi…
03d5929 
…c#80).

Co-authored-by: Arnaud Dufour <[email protected]>
Co-authored-by: Guillaume Gilles <[email protected]>
@taher100 @VictorKL @qdelcourte
TEST: Tests for cloud and fragment view (closes Hypertopic#48 and Hyp…
8c45887 
…ertopic#80).

Co-authored-by: Taher Kamoun <[email protected]>
Co-authored-by: Victor Kodais-Loquet <[email protected]>
Co-authored-by: Quentin Delcourte <[email protected]>
@benel benel added the Draft label Mar 19, 2020
@benel benel changed the title Final version group entretien FEATURE: Topic cloud & fragment view Apr 28, 2020
@benel benel marked this pull request as draft April 29, 2020 09:48
@benel benel removed the Draft label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benel benel benel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud9145 @benel