Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fragments mode #48

Open
6 tasks
benel opened this issue Jun 14, 2017 · 8 comments
Open
6 tasks

Switch to fragments mode #48

benel opened this issue Jun 14, 2017 · 8 comments

Comments

@benel
Copy link
Member

benel commented Jun 14, 2017

Description

What is the valuable outcome that cannot be achieved with current features?

For which stakeholder (people, role, project, domain) is it important?

Which user action should be enabled (or restricted)? For who?

Additional details (solutions you think about, or workarounds you tried)

Deliverables status

Phase 1

  • Scenarios (Gherkin)
  • Mockups
  • Implementation strategy

Phase 2

  • Acceptance tests (Capybara)
  • Implementation

Phase 3

  • Screencast
@GuillaumeGilles42
Copy link

does the fragment view make sense for picture documents or other type than cassandre end lasuli?

@benel
Copy link
Member Author

benel commented May 10, 2019

does the fragment view make sense for picture documents or other type than cassandre end lasuli?

@GuillaumeGilles42 You shoud ask @Hypertopic/if05-p19.

@vl-gx
Copy link

vl-gx commented May 16, 2019

Related Mockup :

Ticket1-Maquette

@benel
Copy link
Member Author

benel commented May 16, 2019

@liyangsifei

In the fragment part of this view (right side), it shows only the fragment related to the sub-category selected or the item with the fragments colored?

Last week, I got that your team had decided (at last) to show all the fragments at the same time.
Always design the most simple solution (esp. there is a risk that the "enhanced" version is worse for users than the simple one). It seems that @valentin-utt's mockup goes in this way.

@valentin-utt This is an interesting mockup, however I see that you decided to group fragments according to topics rather than according to memos. Is there a reason for this? I find it quite surprising since:

  • we don't understand then the link between fragments and memos that are displayed,
  • the links between topics and items (and then fragments) are already handled (much more powerfully) by topic selection (and please note that grouping and selecting are very similar in their use).
  • this is not compatible with the existing display therefore it will require more work by coders to implement it and by users to understand it.

A much simpler design would have been a basic table-like layout for grouping fragments with their related memo. Did you consider it?

@vl-gx
Copy link

vl-gx commented May 17, 2019

Thank you for your advice, a simpler way of grouping the items could be this way :
Maquette V2 :
image

@benel
Copy link
Member Author

benel commented May 17, 2019

@valentin-utt

  • Which fragment corresponds to which memo? The third one seems to be partly in David1 and in David2, which is incompatible with the definition of a fragment. OR are all of them related to David1 because it would be selected?
    Then I'm still unsure if all your team agrees on the way it should work. Last week, I got that your team had decided (at last) to show all the fragments at the same time (therefore with no item selection at all). Always design the most simple solution (esp. there is a risk that the "enhanced" version is worse for users than the simple one).

  • A table-like layout doesn't mean that you should draw borders. It's just a way to use both the vertical and horizontal axes to show links or similarity between data.

GuillaumeGilles42 added a commit to GuillaumeGilles42/Porphyry that referenced this issue May 20, 2019
@vl-gx
Copy link

vl-gx commented May 27, 2019

The new version of the mockups (V3) are as follow :

IF05_3

Notice that the black mouse pointer symbolizes the link to the coresponding fragment in cassandre website. The items are not selectable anymore compared to previous version.

IF5_2

The second scrennshot illustrate the use of the topic section, the selection of one topic restric the table view to the linked fragments.

Which fragment corresponds to which memo?  Are all of them related to David1 because it would be selected?

This is what was planned with the previous version of the mokups.

  Then I'm still unsure if all your team agrees on the way it should work. Last week, I got that your team had decided (at last) to show all the fragments at the same time (therefore with no item selection at all). Always design the most simple solution (esp. there is a risk that the "enhanced" version is worse for users than the simple one).

Indeed, there was a misenderstanding about how we should display the fragments, the new mockups take this remark into account.

A table-like layout doesn't mean that you should draw borders. It's just a way to use both the vertical and horizontal axes to show links or similarity between data.

This is an interesting point, however after discussion with the team we choose to use borders to :

  1. Make the separation between fragments more readable (some fragments are very short, on the others hand some can span multiple lines).

  2. To clearly see with which item the fragment is associated with.

@arnaud9145
Copy link

arnaud9145 commented Jun 6, 2019

Capture d’écran 2019-06-06 à 09 29 37

This is what implementation looks like today

arnaud9145 pushed a commit to GuillaumeGilles42/Porphyry that referenced this issue Jun 14, 2019
first version of fragment view without name of the type of the fragament

fixed misused of state

improvement of the switch in fragment mode

generate the view that describe in the maquet of issus Hypertopic#48

correction header of the table

improvement of the view fragment in response of the reflexion made by valentin

Fixed viewpoint selection with fragments not working

move of the link to cassandre in order to improve the the comprehension of the place where the link go

fixed badge count

removed unused variable

linting

changed bind to arrowfunction

changed favicon

correction de la réduction de sélection des fragments

added cloudview

changed tag background color in cloud
sab91 pushed a commit to sab91/Porphyry that referenced this issue Jun 21, 2019
sab91 pushed a commit to sab91/Porphyry that referenced this issue Jun 21, 2019
sab91 pushed a commit to GuillaumeGilles42/Porphyry that referenced this issue Jun 21, 2019
…c#80).

Co-authored-by: Arnaud Dufour <[email protected]>
Co-authored-by: Guillaume Gilles <[email protected]>
sab91 pushed a commit to GuillaumeGilles42/Porphyry that referenced this issue Jun 21, 2019
…ertopic#80).

Co-authored-by: Taher Kamoun <[email protected]>
Co-authored-by: Victor Kodais-Loquet <[email protected]>
Co-authored-by: Quentin Delcourte <[email protected]>
@Hypertopic Hypertopic deleted a comment from Double-Ramzi Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants