fixes #53 - changing propValue.toArray() to propValue.valueSeq().toAr… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alueSeq().toArray() for immutable v4 compatibility
|
@HurricaneJames if you aren't maintaining this library, would you like to give me access to push this change through? This will become more critical once v4 of Immutable is completely released. |
|
@HurricaneJames Any updates on this? |
amaingot
approved these changes
Mar 22, 2018
|
Can we get this pushed? |
|
@HurricaneJames I'm going to close this PR if you don't want it merged. I'll give it a week or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of
.valueSeq().toArray()for resolving the values of an iterable as it now returns entries in the case of Maps in immutable v4.