Incompatible with immutable v4.0.0-rc9 #53
Comments
jchorl
added a commit
to jchorl/vaelt
that referenced
this issue
Mar 24, 2018
also needed to fork react-immutable-proptypes because that broke with the upgrade. See HurricaneJames/react-immutable-proptypes#53
mechanicalchopsticks
added a commit
to mechanicalchopsticks/react-immutable-proptypes
that referenced
this issue
Nov 26, 2018
- changing `propValue.toArray()` to `propValue.valueSeq().toArray()` for immutable v4 compatibility
HurricaneJames
added a commit
that referenced
this issue
Mar 13, 2020
…ompat fixes #53 - changing propValue.toArray() to propValue.valueSeq().toAr…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per the changelog of immutable v4,
KeyedCollection.toArray()returns an array of tuples. In react-immutable-proptypes, toArray is used in the validator of the iterable type checker.Instead, it should call
.valueSeq().toArray()to ensure that it operates on values and not on entries.The text was updated successfully, but these errors were encountered: