Added pt-BR NumberToWords localisation #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e language Name aswell. This is needed for languages that can be ambiguous in Two Letter ISO Code (pt-BR, pt-PT both have 'pt' Two Letter ISO code).
…e language Name aswell. This is needed for languages that can be ambiguous in Two Letter ISO Code (pt-BR, pt-PT both have 'pt' Two Letter ISO code).
…factories. Better NumerToWordsFactoryTests formatting.
Closed
MehdiK
pushed a commit
that referenced
this pull request
Apr 12, 2014
|
|
||
| namespace Humanizer.Tests.Localisation | ||
| { | ||
| public class NumberToWordsFactoryTests |
There was a problem hiding this comment.
I don't think this class provides much benefit as everything asserted here is already being tested much more thoroughly elsewhere. So removing it.
|
This is merged now. Thanks a lot for fixing the issues and adding the smarter factory. I made a few small changes that I'd appreciate if you could review. The commit can be found here. |
|
This is now published to NuGet as v1.21.1. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.