-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locales are limited to TwoLetterISOLanguageName #168
Comments
Good point. Wanna send me a PR for that? :) I also would really like to see some failing tests with the current implementation. The pt-BR and pt-PT case you've commented on comes to mind. |
I'll look into this when I get home tonight. |
This is now fixed in #194 |
Thanks @akamud for pointing this out. FWIW if you put |
Oh, didn't know about that. Thanks for the info! :) |
on
NumberToWordsExtension
class:if (ConverterFactories.TryGetValue(CultureInfo.CurrentUICulture.TwoLetterISOLanguageName, out converterFactory))
this sentence is limiting the locale awareness of the library. There is room here for improvement. It could be implemented the same way resource files are located.
xx-XX first if there is a match, xx next, and default for last.
The text was updated successfully, but these errors were encountered: