Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locales are limited to TwoLetterISOLanguageName #168

Closed
joaomatossilva opened this issue Apr 10, 2014 · 6 comments
Closed

locales are limited to TwoLetterISOLanguageName #168

joaomatossilva opened this issue Apr 10, 2014 · 6 comments

Comments

@joaomatossilva
Copy link

on NumberToWordsExtension class:

if (ConverterFactories.TryGetValue(CultureInfo.CurrentUICulture.TwoLetterISOLanguageName, out converterFactory))

this sentence is limiting the locale awareness of the library. There is room here for improvement. It could be implemented the same way resource files are located.
xx-XX first if there is a match, xx next, and default for last.

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Good point. Wanna send me a PR for that? :)

I also would really like to see some failing tests with the current implementation. The pt-BR and pt-PT case you've commented on comes to mind.

@akamud
Copy link
Contributor

akamud commented Apr 10, 2014

I'll look into this when I get home tonight.

@akamud
Copy link
Contributor

akamud commented Apr 12, 2014

This is now fixed in #194

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Thanks @akamud for pointing this out. FWIW if you put fixes #168 in your PR description merging that would close this issue automatically too.

@MehdiK MehdiK closed this as completed Apr 12, 2014
@akamud
Copy link
Contributor

akamud commented Apr 12, 2014

Oh, didn't know about that. Thanks for the info! :)

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

No worries. More info here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants