Feature/room ownership #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brianpeiris
commented
Jan 11, 2019
brianpeiris
commented
- Adds a sign-in/out link to the home page
- Adds auth tokens to room creation and room join
gfodor
reviewed
Jan 12, 2019
src/hub.js
Outdated
| @@ -531,6 +531,10 @@ document.addEventListener("DOMContentLoaded", async () => { | |||
|
|
|||
| const pushSubscriptionEndpoint = await subscriptions.getCurrentEndpoint(); | |||
| const joinPayload = { profile: store.state.profile, push_subscription_endpoint: pushSubscriptionEndpoint, context }; | |||
| const { token } = store.state.credentials; | |||
| if (token) { | |||
| joinPayload.token = token; | |||
There was a problem hiding this comment.
notes from other PR, but these should prob be auth_token vs perm_token
gfodor
reviewed
Jan 12, 2019
| @@ -41,12 +45,18 @@ class HomeRoot extends Component { | |||
| state = { | |||
| environments: [], | |||
| dialog: null, | |||
| signedIn: null, | |||
There was a problem hiding this comment.
nit, maybe make this authenticated or signedIn everywhere, not both
gfodor
reviewed
Jan 12, 2019
| document.location = `/hub.html?hub_id=${hub.hub_id}`; | ||
| } | ||
| createRoom = () => { | ||
| createAndRedirectToNewHub(this.state.customRoomName, this.props.sceneId); |
|
LGTM mod the changes to move away from Also, nice to see the auth channel stuff migrated over to the home page nicely. 😅 |
|
This was referenced Jan 16, 2019
|
Merging in #843 |
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.