New Coat of Paint #599
Merged
New Coat of Paint #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 2, 2018
Closed
Closed
brianpeiris
reviewed
Oct 2, 2018
src/hub.html
Outdated
| @@ -10,6 +10,7 @@ | |||
| <link rel="shortcut icon" type="image/png" href="/favicon.ico"> | |||
| <title>Get together | Hubs by Mozilla</title> | |||
| <link href="https://fonts.googleapis.com/css?family=Zilla+Slab:300,300i,400,400i,700" rel="stylesheet"> | |||
There was a problem hiding this comment.
It looks like we've stopped using Zilla Slab completely. Might as well remove this font reference and cut the dead weight?
brianpeiris
reviewed
Oct 2, 2018
| </p> | ||
| <p> | ||
| The <b>Bubble Toggle</b> hides avatars that enter your personal space. | ||
| The <b>Pause/Resume Toggle</b> pauses all other avatars and lets you block others or remove objects. |
There was a problem hiding this comment.
Should we change the media "Delete" buttons to read "Remove" instead? There are three of them in the HTML: https://github.com/mozilla/hubs/blob/feature/new-coat-of-paint/src/hub.html#L171
There was a problem hiding this comment.
ah yes, i meant to do this! thanks
brianpeiris
approved these changes
Oct 2, 2018
| </div> | ||
| <div className={styles.bottom}> | ||
| <div> | ||
| <FormattedMessage id="home.made_with_love" /> |
| min-height: 100%; | ||
| z-index: 1; | ||
| } | ||
|
|
||
| :local(.header-content) { | ||
| padding: 0.5em 1.75em 0.5em 1.75em; | ||
| background-color: $darkest-transparent; | ||
| background-color: white; |
There was a problem hiding this comment.
I recall reading a best practices doc at some point that mentioned it's a bit unsophisticated to use a fully-white white or a fully-black black in your design. I guess we do a lot of that, but perhaps something to keep in mind for the next iteration.
e.g. If feels like the bright white in both the header and the now blown-out background video draw my attention more than the actual UI elements.
|
|
||
| @media (min-width: 769px) and (min-height: 421px) { | ||
| flex: 1; | ||
| } | ||
| @media (max-width: 768px) , (max-height: 420px) { | ||
| margin: 16px 8px; | ||
| margin: 16px 0; | ||
| padding: 2px 8px; | ||
| } | ||
| :local(.occupant-count) { | ||
| margin: 0 12px; |
There was a problem hiding this comment.
Looks better if you remove the margin-right on this, now that it's in a rounded container.
| @@ -43,14 +43,16 @@ | |||
| @extend %glass-text; | |||
|
|
|||
| appearance: none; | |||
| background-color: rgba(64, 64, 64, 0.2); | |||
| background-color: white; | |||
There was a problem hiding this comment.
The dropdown arrow is still white, so you can't see it now.
There was a problem hiding this comment.
these were images I forgot to convert to black, done
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh the style of the 2D parts of the app based on the new designs