Lobby #594
Closed
Lobby #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brianpeiris
suggested changes
Oct 1, 2018
src/scene-entry-manager.js
Outdated
| }); | ||
| const hudController = this.playerRig.querySelector("[hud-controller]"); | ||
| hudController.setAttribute("hud-controller", { showTip: !this.store.state.activity.hasFoundFreeze }); | ||
| document.querySelector("a-scene").emit("username-changed", { username: displayName }); |
There was a problem hiding this comment.
Use this.scene instead of querying the selector again.
src/scene-entry-manager.js
Outdated
| if (screenEntity) { | ||
| screenEntity.setAttribute("visible", sharingScreen); | ||
| } else if (sharingScreen) { | ||
| const sceneEl = document.querySelector("a-scene"); |
src/hub.js
Outdated
| e.preventDefault(); | ||
| }); | ||
| if (isBotMode) { | ||
| entryManager.enterSceneWhenLoaded(new MediaStream(), false); |
There was a problem hiding this comment.
This method is never called with true instead of false.
There was a problem hiding this comment.
I think that's OK -- i defined the public interface of this function to match that of enterScene
|
|
||
| // Connect to reticulum over phoenix channels to get hub info. | ||
| const hubId = qs.get("hub_id") || document.location.pathname.substring(1).split("/")[0]; | ||
| console.log(`Hub ID: ${hubId}`); | ||
|
|
||
| const socket = connectToReticulum(isDebug); | ||
| const channel = socket.channel(`hub:${hubId}`, {}); | ||
| let loadedSceneUrl = null; |
There was a problem hiding this comment.
Looks like this loadedSceneUrl mechanism was removed in the refactor. Wasn't it needed for a proper re-join?
There was a problem hiding this comment.
ah, yeah so the way I detect if its a reconnect is via NAF.connection.isConnected() -- I think that incidentally works but probably not the best thing to check. any suggestions?
| @@ -459,7 +456,9 @@ | |||
| id="environment-root" | |||
| nav-mesh-helper | |||
| static-body="shape: none;" | |||
| ></a-entity> | |||
| > | |||
| <a-entity id="environment-scene"/> | |||
There was a problem hiding this comment.
You've replaced environment-root with environment-scene? Looks like environment-root is not referenced anywhere now. You'll probably want to move the nav-mesh-helper and static-body components over if that's the case.
There was a problem hiding this comment.
so I believe the scene structure is unchanged, but previously the join code created the environment-scene element and a few things closed over it and used it (it did not have a name in the dom, it was passed around in a var.) so i just moved that into the DOM directly so those closures could get lifted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pre entry lobby so users can see what is going on before they chose to join a room.
Does a ton of refactoring and cleanup of
hub.js, breaking some code out intoSceneEntryManagerand lifting a bunch of closures into top level functions, among other things. (hopefully this makes @mquander happy :)) There's more I could probably do but this is a good first step.Removes the speculative Daydream entry mode
Changes the hub landing page to connect to Janus and put the user into a spectator mode which automatically pans the camera through the scene, but allows the user to rotate it.
More visual design changes forthcoming but this is a basic "lobby" mode. This has two benefits: it allows the user to see what is going on in the room before entering, and also as a bonus causes avatars, objects, etc, to load before entering VR, which avoids the worst hitching.