Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PointLight to bitecs #5932

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add PointLight to bitecs #5932

merged 1 commit into from
Mar 15, 2023

Conversation

takahirox
Copy link
Contributor

This PR adds PointLight to bitecs, similar to #5918.

We may want to deprecate light components at some point and encourage to use glTF lights extension, but we don't need to drop the support right now.

@takahirox takahirox mentioned this pull request Feb 6, 2023
Open
50 tasks
netpro2k
netpro2k approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@netpro2k netpro2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Same thoughts on typing as the other similar inflator PRs. We should just figure out what we want to do and apply it to all of them. We can do it all at once in a separate PR too, its not particularly important.

@takahirox takahirox merged commit 250834b into master Mar 15, 2023
@takahirox takahirox deleted the BitECSPointLight branch March 15, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnshaughnessy johnshaughnessy johnshaughnessy approved these changes

@netpro2k netpro2k netpro2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takahirox @netpro2k @johnshaughnessy