Add AmbientLights to bitecs #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
reviewed
Feb 2, 2023
src/bit-components.js
Outdated
| @@ -47,6 +47,7 @@ export const AEntity = defineComponent(); | |||
| export const Object3DTag = defineComponent(); | |||
| export const GLTFModel = defineComponent(); | |||
| export const LightTag = defineComponent(); | |||
| export const AmbientLight = defineComponent(); | |||
There was a problem hiding this comment.
We might want to call this AmbientLightTag just to avoid ambiguity and having to rename when importing AmbientLight from Three.
| intensity: number; | ||
| }; | ||
|
|
||
| export function inflateAmbientLight(world: HubsWorld, eid: number, params: AmbientLightParams) { |
There was a problem hiding this comment.
In the aframe component we have default values. We probably want to preserve those. https://github.com/mozilla/hubs/blob/master/src/components/ambient-light.js#L3-L4
We can do this easily with Object.assign() like https://github.com/mozilla/hubs/blob/master/src/inflators/simple-water.ts#L34
Deprecate light components and encourage glTF lights extension instead? If so, yes I absolutely agree. |
hrithikwins
approved these changes
Feb 3, 2023
takahirox
force-pushed
the
BitECSAmbientLight
branch
from
8983e58
to
8f79ccb
Compare
takahirox
force-pushed
the
BitECSAmbientLight
branch
from
8f79ccb
to
9e54209
Compare
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
AmbientLightsto bitecs in the same way asDirectionalLight.