Feature/dark-app-logo #4786
Merged
Feature/dark-app-logo #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
Oct 28, 2021
| import { getColorSchemePref } from "./get-color-scheme-pref"; | ||
|
|
||
| function getCurrentTheme() { | ||
| if (!Array.isArray(themes)) return; |
There was a problem hiding this comment.
I'm concerned about us missing a check for invalid themes json uploaded to APP_CONFIGS and also about the possibility of missing a default theme. I don't think you need to address these concerns in this PR but wanted to put it on your radar.
| import { themes } from "../react-components/styles/theme"; | ||
| import { getColorSchemePref } from "./get-color-scheme-pref"; | ||
|
|
||
| function getCurrentTheme() { |
There was a problem hiding this comment.
Would it be a good idea to reuse this function in theme.js (and possibly also move it to that file)?
| @@ -0,0 +1,7 @@ | |||
| import { themes } from "../react-components/styles/theme"; | |||
|
|
|||
| export function getColorSchemePref() { | |||
There was a problem hiding this comment.
If this is the only use of this function, I would suggest we move it inline to the call site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives hubs cloud users the option of uploading an app-logo image for use in their own dark mode. The theme MUST have a
"darkModeDefault": truein the top level of the object for this to function properly. This value effectively sets that theme to the default dark theme. We use this theme if the user has not specified a theme and prefers a dark color scheme.