Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign In Modal color contrast, difficult to read on dark mode #2773

Closed
yuriaru opened this issue Aug 3, 2020 · 4 comments
Closed

Sign In Modal color contrast, difficult to read on dark mode #2773

yuriaru opened this issue Aug 3, 2020 · 4 comments
Labels
bug good first issue jira-hubs P2 Address when able

Comments

@yuriaru
Copy link

yuriaru commented Aug 3, 2020 •
edited by data-sync-user
Loading

Description
Hub instance is set with Dark Mode on Theme settings. Clicking on the "Sign In" link on the landing page, pops up the Sign-In modal, in which the text is not readable.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Admin and enable Dark Mode on Theme settings.
  2. In a different browser session, on the landing page click the "Sign in " link.
  3. Modal will appear but text is not readable.

Expected behavior
Text should be readable on modal as is in the case once you create a room and try to change the scene or room settings. At that point modal shows fine and text is readable, but when you try to click "Sign In" directly from the home page, the modal shows with white background and very light gray that makes the text unreadable.

Screenshots
Landing Page, after clicking "Sign In"
Screen Shot 2020-08-03 at 11 06 26 AM

Other pages, once you created a room
Screen Shot 2020-07-31 at 12 49 46 PM

┆Issue is synchronized with this Jira Task
@yuriaru yuriaru added bug needs triage For bugs that have not yet been assigned a fix priority labels Aug 3, 2020
@johnshaughnessy johnshaughnessy self-assigned this Aug 3, 2020
@johnshaughnessy johnshaughnessy added this to the Q3 Sprint 2 milestone Aug 3, 2020
@johnshaughnessy johnshaughnessy added P2 Address when able good first issue and removed needs triage For bugs that have not yet been assigned a fix priority labels Sep 8, 2020
@johnshaughnessy johnshaughnessy removed their assignment Sep 21, 2020
@Namanl2001
Copy link

Hey, can I work on this issue?

@yuriaru
Copy link
Author

yuriaru commented Oct 4, 2020 via email

@Namanl2001
Copy link

@yuriaru Thanks. As I am new to this project, can you please guide me, how to proceed further? Which particular files to look into?

@SaravgiYash
Copy link

Hi @yuriaru I would like to work on this issue. Can you please guide me on what all changes do I need to make and in which file?

@misslivirose misslivirose removed this from the Q3 Sprint 2 milestone Feb 17, 2021
@matthewbcool matthewbcool mentioned this issue Oct 7, 2021
Closed
@matthewbcool matthewbcool mentioned this issue Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue jira-hubs P2 Address when able
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@johnshaughnessy @misslivirose @matthewbcool @yuriaru @Namanl2001 @SaravgiYash