Fixes for environment-settings system #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
commented
Sep 22, 2021
| @@ -58,7 +58,8 @@ const extractZipFile = promisifyWorker(new SketchfabZipWorker()); | |||
|
|
|||
| function defaultInflator(el, componentName, componentData) { | |||
| if (!AFRAME.components[componentName]) { | |||
| throw new Error(`Inflator failed. "${componentName}" component does not exist.`); | |||
| console.warn(`Inflator failed. "${componentName}" component does not exist.`); | |||
There was a problem hiding this comment.
We intentionally don't load all components on the scene page, but this causes some models to fail to load. This doesn't seem like it should be fatal, so converted it to a warning.
netpro2k
force-pushed
the
env-settings-fixes
branch
from
ab0d7fd to
3374542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few minor issues brought up with the environment settings system
fixes #4634
fixes #4635