Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Is Always Black Without Skybox #4648

Closed
Exairnous opened this issue Sep 16, 2021 · 3 comments
Closed

Background Is Always Black Without Skybox #4648

Exairnous opened this issue Sep 16, 2021 · 3 comments
Assignees
Labels
bug jira-hubs needs triage For bugs that have not yet been assigned a fix priority

Comments

@Exairnous
Copy link
Contributor

Exairnous commented Sep 16, 2021

Description
When using a scene with a singular color as the background and no skybox, the background is always rendered as black instead of the color set with the Background Color property of the scene.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scene in Spoke with no skybox and the background color set to something other than black.
  2. Publish the scene and note that everything in spoke looks as it should.
  3. Enter a room with that scene.
  4. See that the background or "sky" is pure black.

Here's a link to a test scene: https://hubs.mozilla.com/scenes/BErFYHQ/testbackgroundcolor

Expected behavior
For the background to be rendered with the color that was set in Spoke.

Hardware

  • Device: Laptop
  • OS: Linux (Archlinux, KDE)
  • Browser: Chrome, Firefox

Workaround
You should be able to work around this bug by creating a cube (1000 m, in blender you can scale the default cube by 500 to achieve this) with an unlit material the color you want your background and adding that to your scene at the origin (disable walkable and collidable).

┆Issue is synchronized with this Jira Task

@Exairnous Exairnous added bug jira-hubs needs triage For bugs that have not yet been assigned a fix priority labels Sep 16, 2021
@j-conrad
Copy link
Contributor

I can confirm this bug.
One thing to note: The background color shows correctly in the Lobby view. This tells me it might have something to do with the user camera's clipping values--perhaps the far clip is set too close?
Another scene for testing:
https://hubs.mozilla.com/scenes/SzjM45o

@Exairnous
Copy link
Contributor Author

Interesting, for me the background color shows up black in the lobby, it does show up correctly in the scene preview image and it shows correctly when just viewing the scene link you posted, but not if the scene is in a room.
And thanks for the confirm :)

@netpro2k
Copy link
Contributor

This was a regression with the new environment settings system. It needs to account for scenes that already have a background setting and don't have environment settings component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug jira-hubs needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
Development

No branches or pull requests

4 participants