OB Camera multisampled FB blitting fix #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to ask Oculus Browser team about likely forced multisampling stuffs before going with this change. |
|
I agree, this was just a patch in case there wasn't a better short term alternative. |
brianpeiris
approved these changes
May 22, 2021
There was a problem hiding this comment.
Just to put it in writing here. This looks good to me as long as we're reasonably sure that it doesn't introduce an additional performance penalty. If we can find a more generalized fix in the future, that would also be good, but it seems fine to ship this fix for now. We can always improve on it.
|
Ok, I'm going to land this to get it fixed until we can update ThreeJS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4232
OB Chromium FBs are multisampled by default and they don't allow blitting for multisampled FBs when regions differ. https://chromium.googlesource.com/chromium/src/gpu/+/master/command_buffer/service/gles2_cmd_decoder.cc#8899
We are using
THREE.WebGLRenderTargetso the render buffer shouldn't be multisampled but for some reason they are still forcing it.This PR avoiding blitting for OB and just flips the original camera render target pixels.