Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research on the OB blitting issue/fix #4292

Open
keianhzo opened this issue May 26, 2021 · 1 comment
Open

Research on the OB blitting issue/fix #4292

keianhzo opened this issue May 26, 2021 · 1 comment
Assignees
@keianhzo
Labels
enhancement work that enhances an existing feature jira-hubs

Comments

@keianhzo
Copy link
Contributor

keianhzo commented May 26, 2021 •
edited by data-sync-user
Loading

This was added to overcome a ThreeJS bug in OB. We should research more to find a more elegant solution or open a bug in the ThreeJS repo.

#4255

┆Issue is synchronized with this Jira Task
@keianhzo keianhzo added the enhancement work that enhances an existing feature label May 26, 2021
@keianhzo keianhzo self-assigned this May 26, 2021
@keianhzo
Copy link
Contributor Author

keianhzo commented Aug 9, 2021

r128 does not fix the issue, but this got broken at some point after a past ThreeJS update (before r111). It will require some more research to try to find a more elegant solution.

Updating the title as this isn't true anymore.

@keianhzo keianhzo changed the title Revert OB blitting fix when ThreeJS r128 lands Research on the OB blitting issue/fix Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
enhancement work that enhances an existing feature jira-hubs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keianhzo @johnshaughnessy