Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link behavior for images and videos #3904

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Add link behavior for images and videos #3904

merged 6 commits into from
Feb 16, 2021

Conversation

robertlong
Copy link
Contributor

No description provided.

@robertlong robertlong mentioned this pull request Feb 12, 2021
Merged
netpro2k
netpro2k reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@netpro2k netpro2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if we confirm that sanitizing src isnt breaking sharing of webcam/screen.

src/gltf-component-mappings.js Show resolved Hide resolved
@robertlong robertlong merged commit bb0efe1 into master Feb 16, 2021
@robertlong robertlong deleted the feature/link-thumbnails branch February 16, 2021 23:05
This was referenced Mar 5, 2021
Merged
Merged
@stalgiag stalgiag mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netpro2k netpro2k netpro2k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertlong @netpro2k