Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Images and Videos Linkable #1101

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Make Images and Videos Linkable #1101

merged 4 commits into from
Feb 16, 2021

Conversation

robertlong
Copy link
Contributor

@robertlong robertlong commented Feb 12, 2021

You can now add links to Videos and Images. Just fill out the href field with a url. When someone clicks on the media, they will open up a new tab with that page.

image

Depends on:
Hubs-Foundation/hubs#3904

Copy link
Contributor

@netpro2k netpro2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We might want to hide the link field in cases where it will not be exported to avoid confusion.

src/ui/properties/ImageNodeEditor.js Outdated Show resolved Hide resolved
src/ui/properties/VideoNodeEditor.js Outdated Show resolved Hide resolved
@robertlong robertlong added the whats new Include this PR on the "What's New" page label Feb 16, 2021
@robertlong robertlong merged commit 40d5bfd into master Feb 16, 2021
@robertlong robertlong deleted the feature/link-thumbnails branch February 16, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whats new Include this PR on the "What's New" page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants