Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fr.json #3754

Closed
wants to merge 27 commits into from
Closed

Create fr.json #3754

wants to merge 27 commits into from

Conversation

cbo04
Copy link
Contributor

@cbo04 cbo04 commented Jan 23, 2021

French translation

Copy link
Contributor

@Slayug Slayug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have done some suggestions to your file.

The main difference is hall to hall d'attente.

src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Outdated Show resolved Hide resolved
cbo04 and others added 24 commits February 4, 2021 19:52
@cbo04
Copy link
Contributor Author

cbo04 commented Feb 4, 2021

Thanks @Slayug !
Just a few questions in comments

src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/assets/locales/fr.json Show resolved Hide resolved
src/assets/locales/fr.json Show resolved Hide resolved
Copy link
Contributor Author

@cbo04 cbo04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Slayug
sorry I am not sure how to close a suggestion of yours when mistaken, or change things like adding a "s" in "Aucuns Favoris". It is my first contribution in GitHub and I don't know the workflow yet.

src/assets/locales/fr.json Show resolved Hide resolved
@Slayug
Copy link
Contributor

Slayug commented Feb 9, 2021

sorry I am not sure how to close a suggestion of yours when mistaken

Is there any close/resolved button when you click on the three dots at the left top ?
Else if you have to change anything do a new commit, or change directly file here.

src/assets/locales/fr.json Show resolved Hide resolved
@cbo04
Copy link
Contributor Author

cbo04 commented Feb 10, 2021

Hi Alex @Slayug
Thanks for helping. I have read the file once again to check it all. 👍
What is the next step?

@Slayug
Copy link
Contributor

Slayug commented Feb 12, 2021

@cbo04 I think it could be great to have only on PR instead of these:

next step will be: review by a maintainer @emclaren ?

from #3752

EDIT I'm sorry I finally tried the translation with the client, and I noticed we do not have all translation when I compared with the extracted en.json with the npm run intl-extract-en-locale, lot of are missing or haven't the same key.
I will do a new PR in the next few days, do not take account of cbo04#1 @cbo04

@Slayug Slayug mentioned this pull request Feb 12, 2021
@ssm2017
Copy link
Contributor

ssm2017 commented Feb 12, 2021

Hello
I have not seen this pr before posting my one.
The code from @cbo04 looks like taken from the old UI.
My code is taken from the new UI (and not working on the old UI).
I have kept some words like "room" instead of "salle" but i can change it and take inspiration from @cbo04 code.
another decision i have made was to not translate the debug panel.
How can we proceed (i update my code with the sentences from @cbo04 or should i purpose a pr to the @CB04 repo or inverse) ?

@cbo04
Copy link
Contributor Author

cbo04 commented Feb 12, 2021

Hello @ssm2017
I have translated the old UI just 2 days before the new one 😂 bad timing!
Let me know if I can help in merging the files

(are you part of Le Hublot team...?)

Copy link
Contributor

@ioioioio ioioioio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work :)

"tips.mobile.feedback-link": "Dites-le au canard.",
"tips.desktop.video_share_mode": "Diffusion de votre écran en cours. Cliquez à nouveau pour arrêter la diffusion.",
"tips.desktop.pen_mode": "Appuyez sur ECHAP ou faites un clic droit pour lâcher le stylo. Ctrl-Z pour annuler.",
"tips.desktop.mute_mode": "Votre micré est coupé. Cliquez ou appuyez sur M pour le rallumer.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Cliquez ou appuyez sur M" sounds weird to me. Maybe "Cliquez sur le bouton ou appuyez sur M" would be better?

Suggested change
"tips.desktop.mute_mode": "Votre micré est coupé. Cliquez ou appuyez sur M pour le rallumer.",
"tips.desktop.mute_mode": "Votre micro est coupé. Cliquez ou appuyez sur M pour le rallumer.",

"tips.desktop.spawn_menu-pre": "Pour créer des objets, cliquez sur le bouton ",
"tips.desktop.spawn_menu-post": "en haut de votre écran, ou appuyez sur Ctrl 1 à 7.",
"tips.desktop.freeze_gesture": "Appuyez et maintenez la barre d'espace pour afficher le menu des objets.",
"tips.desktop.menu_hover": "A présent, pointez le curseur vers un objet pour afficher le menu.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tips.desktop.menu_hover": "A présent, pointez le curseur vers un objet pour afficher le menu.",
"tips.desktop.menu_hover": "À présent, pointez le curseur vers un objet pour afficher le menu.",

"tips.desktop.object_recenter_button-post": " pour vous retrouver en face de l'objet. Très utile si vous le faites tomber !",
"tips.desktop.object_scale": "Maintenez SHIFT et faites défiler le curseur pour l'agrandir ou le rétrécir.",
"tips.desktop.pen_color": "Utilisez SHIFT-Q et SHIFT-E pour modifier la couleur du stylo.",
"tips.desktop.pen_size": "Maintenez SHIFT et faites défilez le curseur pour modifier la taille du stylo.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tips.desktop.pen_size": "Maintenez SHIFT et faites défilez le curseur pour modifier la taille du stylo.",
"tips.desktop.pen_size": "Maintenez SHIFT et faites défiler le curseur pour modifier la taille du stylo.",

"commands.rename": "Renommer la salle.",
"commands.help": "Afficher l'aide.",
"commands.leave": "Se déconnecter de la salle.",
"commands.duck": "Le canard approuve. Coin.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,465 @@
{
"app-name": "Application",
"editor-name": "Editeur de scène",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"editor-name": "Editeur de scène",
"editor-name": "Éditeur de scène",

"room-settings.spawn_and_move_media": "Créer et déplacer des objets",
"room-settings.spawn_camera": "Créer des appareils photos",
"room-settings.spawn_drawing": "Créer des dessins",
"room-settings.pin_objects": "Epingler des objets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"room-settings.pin_objects": "Epingler des objets",
"room-settings.pin_objects": "Épingler des objets",

"room-settings.revoke-confirm-no": "non",
"room-settings.revoke": "révoquer",
"room-settings.access-public": "Publique",
"room-settings.access-public-subtitle": "Listé sur la page d'accueil",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"room-settings.access-public-subtitle": "Listé sur la page d'accueil",
"room-settings.access-public-subtitle": "Listée sur la page d'accueil",

"entry.enter-room": "Entrer dans la salle",
"entry.leave-room": "Quitter la salle",
"entry.change-scene": "Choisir la scène",
"entry.in-lobby-notice": "Vous observez cette salle depuis la salle d'attente.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"entry.in-lobby-notice": "Vous observez cette salle depuis la salle d'attente.",
"entry.in-lobby-notice": "Vous observez cette salle depuis le hall d'attente.",

"preferences.category_controls": "Contrôles",
"preferences.category_misc": "Divers",
"preferences.category_movement": "Mouvement",
"preferences.category_touchscreen": "Ecran tactile",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"preferences.category_touchscreen": "Ecran tactile",
"preferences.category_touchscreen": "Écran tactile",

"preferences.enableOnScreenJoystickLeft": "Activer le clic gauche du joystick sur l'écran pour se déplacer",
"preferences.enableOnScreenJoystickRight": "Activer le clic droit du joystick sur l'écran pour regarder autour de soi",
"preferences.enableGyro": "Activer le gyroscope (si compatible avec le navigateur / l'appareil)",
"preferences.invertTouchscreenCameraMove": "Inverser la direction du mouvement de caméra pour les écrans tactiles",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"preferences.invertTouchscreenCameraMove": "Inverser la direction du mouvement de caméra pour les écrans tactiles",
"preferences.invertTouchscreenCameraMove": "Inverser la direction du mouvement de la caméra pour les écrans tactiles",

@ssm2017
Copy link
Contributor

ssm2017 commented Feb 15, 2021

Hello
What do you plan @cbo04 and @ioioioio ?
We have 2 translations : old ui and new ui
This pr is for the old ui and my one is for the new ui.
I will update my translation to reflect the @cbo04 better translated sentences but i would like that @cbo04 is mentionned.
note : yes i am from Le Hublot's team

ssm2017 added a commit to ssm2017/hubs that referenced this pull request Feb 15, 2021
Reflected Hubs-Foundation#3754
- custom -> personnalisé
- skin -> costume
- room -> salle
- survol -> déplacement en volant
- kicker -> éjecter (non pas bannir)
- mute -> couper le micro
- lobby -> hall d'attente
@ioioioio
Copy link
Contributor

Oh, did not get which pr would be merged into which one 😅

Well, I'll give a look to the other one later.

@Slayug
Copy link
Contributor

Slayug commented Feb 16, 2021

@ssm2017 @ioioioio @cbo04 I think it's better to merge the other PR #3897, it contains fr.json and locale_config.js files, traductions for new UI.

I have started to review #3897, @ioioioio @cbo04 you can also review it to have better results

@cbo04
Copy link
Contributor Author

cbo04 commented Feb 17, 2021

@ioioioio thanks for your review, let's do the same on @ssm2017 's file! 💪 #3897

@robertlong
Copy link
Contributor

Closing and moving to #3897

@robertlong robertlong closed this Feb 18, 2021
@abze-mv
Copy link

abze-mv commented Feb 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants