Room join error message #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpeiris
suggested changes
Apr 13, 2018
src/react-components/ui-root.js
Outdated
| <div className="ui-alert-container"> | ||
| <div className="ui-interactive ui-alert-box"> | ||
| <div className="fatal-error-panel"> | ||
| <div className="fatal-error__title">Error Joining Room</div> |
| @@ -35,7 +35,7 @@ | |||
| "minijanus": "^0.5.0", | |||
| "mobile-detect": "^1.4.1", | |||
| "moving-average": "^1.0.0", | |||
| "naf-janus-adapter": "https://github.com/mozilla/naf-janus-adapter#feature/disconnect", | |||
| "naf-janus-adapter": "https://github.com/mozilla/naf-janus-adapter", | |||
There was a problem hiding this comment.
Please publish to npm (use the release script) and point to a version
|
Superseded by #208 |
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a really simple error message (with no attempt to reconnect or antyhing) if joining the room fails for any reason. The only expected error for this is room cap.
This requires corisponding changes in
networked-aframeandnaf-janus-adapterwhich should be merged firstmozilla/naf-janus-adapter#31
networked-aframe/networked-aframe#125 (only needs to be merged into our dev fork before this PR)
This resolves #95 on the client side (already resolved on janus side)