Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a room size cap #95

Closed
gfodor opened this issue Mar 25, 2018 · 5 comments
Closed

Add a room size cap #95

gfodor opened this issue Mar 25, 2018 · 5 comments
Assignees
Labels
enhancement work that enhances an existing feature

Comments

@gfodor
Copy link
Contributor

gfodor commented Mar 25, 2018

We should limit room capacity to some reasonable amount. (Proposal: 100)

Unsure if this should be server or client enforced.

@gfodor gfodor added enhancement work that enhances an existing feature Duck MVP labels Mar 25, 2018
@gfodor
Copy link
Contributor Author

gfodor commented Mar 28, 2018

after discussions it sounded like a more conservative value may be beneficial for initial launch. iirc 12 sounded like the most mutually agreed upon value as balancing usefulness vs mitigating concerns about too many people in a room at once.

@gfodor
Copy link
Contributor Author

gfodor commented Apr 2, 2018

Lets do 12. I believe this should be an SFU API enhancement so assigned to you @mquander -- feel free to kick back to me if you believe a client-oriented approach is the right move if the server based approach is too involved. The cap can be a soft cap, we basically just want to make it so if a link is posted to a public internet and is flooded it will eventually converge to not allowing more people in.

@mqp
Copy link
Contributor

mqp commented Apr 2, 2018

This is fine. I'll implement it as a response to the "join" message to Janus.

@netpro2k
Copy link
Contributor

netpro2k commented Apr 3, 2018

Cool, I can do the client side work for this. @mquander just let me know when its up and what response to expect, then assign the issue to me.

@gfodor
Copy link
Contributor Author

gfodor commented Apr 23, 2018

#208

@gfodor gfodor closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants