Entry flow UX changes - Part 2 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
brianpeiris
commented
Apr 12, 2018
| <iframe | ||
| className="profile-entry__avatar-selector" | ||
| src={`/${this.props.htmlPrefix}avatar-selector.html#avatar_id=${this.state.avatar_id}`} | ||
| ref={ifr => (this.avatarSelector = ifr)} | ||
| /> | ||
| {!this.props.store.state.profile.has_agreed_to_terms && ( |
There was a problem hiding this comment.
@gfodor does it make sense to hide the term checkbox after the user has agreed to it?
brianpeiris
commented
Apr 12, 2018
| "profile.terms.privacy": "privacy policy", | ||
| "profile.terms.conjunction": "and", | ||
| "profile.terms.tou": "terms of use", | ||
| "profile.terms.suffix": ".", |
There was a problem hiding this comment.
@gfodor Terms copy needs your review.
There was a problem hiding this comment.
yes we can send this to legal once they get things wrapped up
brianpeiris
commented
Apr 12, 2018
| <FormattedMessage id="profile.terms.conjunction" />{" "} | ||
| <a className="profile-entry__terms__link" target="_blank" href="/terms"> | ||
| <FormattedMessage id="profile.terms.tou" /> | ||
| </a> |
There was a problem hiding this comment.
@gfodor Linking to non-existent /privacy and /terms urls for now.
gfodor
reviewed
Apr 12, 2018
src/hub.js
Outdated
|
|
||
| getAvailableVREntryTypes().then(availableVREntryTypes => { | ||
| uiRoot.setState({ availableVREntryTypes }); | ||
| uiRoot.handleForcedVREntryType(); | ||
| console.log('BPDEBUG availableVREntryTypes', availableVREntryTypes); |
gfodor
reviewed
Apr 12, 2018
src/hub.js
Outdated
| const uiRoot = mountUI(scene); | ||
| mountUI(scene); | ||
|
|
||
| const remountUI = () => { |
There was a problem hiding this comment.
maybe set things up so instead of having to mutate uiRootProps everywhere, the k/vs to alter are arguments to this function?
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit list for changes.
For #116. Building on #175.