Entry flow UX changes - Part 1 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
brianpeiris
commented
Apr 10, 2018
src/hub.js
Outdated
| // Wait a tick so that the environments actually render. | ||
| setTimeout(() => scene.renderer.animate(null)); | ||
| // Wait a tick plus some margin so that the environments actually render. | ||
| setTimeout(() => scene.renderer.animate(null), 100); |
There was a problem hiding this comment.
Turns out a timeout of 0 would sometimes partially render the environment.
brianpeiris
changed the title
|
Suggestions as discussed:
|
gfodor
reviewed
Apr 12, 2018
| @@ -28,17 +28,29 @@ | |||
| @extend %rounded-border; | |||
| @extend %default-font; | |||
|
|
|||
| appearance: none; | |||
gfodor
reviewed
Apr 12, 2018
| color: white; | ||
| font-size: 1.1em; | ||
| width: 90%; | ||
| } | ||
|
|
||
| &__mic-icon { | ||
| pointer-events: none; |
|
lgtm! (not sure if you want to cut a new PR for those additional changes, this PR lgtm as-is) |
|
(not sure what is up with build though) |
|
RE: Random names / possibly animal names... There are a wide range of duck (and other waterfowl) species as listed here: https://www.thespruce.com/duck-species-list-385436 |
Entry flow UX changes - Part 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit list for changes.
For #116