Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM packages exports and metadata #705

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

romelperez
Copy link
Contributor

@romelperez romelperez commented Nov 17, 2022

Fixes #698

  • Add NPM packages files setting with only ./build package folder.
  • Add NPM packages metadata.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

⚠️ No Changeset found

Latest commit: 75d4bba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 17, 2022

@romelperez is attempting to deploy a commit to the HoudiniGraphQL Team on Vercel.

A member of the Team first needs to authorize it.

@romelperez romelperez changed the title fix: #698 NPM packages exports and metadata Fix NPM packages exports and metadata Nov 17, 2022
@AlecAivazis AlecAivazis merged commit f956f68 into HoudiniGraphql:main Nov 17, 2022
@romelperez
Copy link
Contributor Author

The final build folder in the NPM package release has 26MB. But anyway, it will prevent to ship unwanted code to NPM.

endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Houdini package publish files
2 participants