Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Houdini package publish files #698

Closed
romelperez opened this issue Nov 16, 2022 · 2 comments · Fixed by #705
Closed

Houdini package publish files #698

romelperez opened this issue Nov 16, 2022 · 2 comments · Fixed by #705

Comments

@romelperez
Copy link
Contributor

romelperez commented Nov 16, 2022 •
edited
Loading

Describe the bug

The NPM package houdini currently has 27MB in file size since it is not explicitly defining package exported files.

The package can use the package.json files setting to define what files to publish to NPM. This way the final bundle file size should be reduced.

Let me know if you need help and I can submit a PR with it.

Severity

annoyance

Steps to Reproduce the Bug

Go to https://www.npmjs.com/package/houdini and check the "Unpacked Size" field value.

Reproduction

No response
@romelperez romelperez changed the title Houdini package exposed files Houdini package publish files Nov 16, 2022
@AlecAivazis
Copy link
Collaborator

Thanks for reporting this @romelperez! If you wanna throw a PR together to fix this, i'd gladly review it. While you're at it, mind handling #657?

@romelperez
Copy link
Contributor Author

Hey, perfect, I'll work on those two! 🙌

romelperez added a commit to romelperez/houdini that referenced this issue Nov 17, 2022
@romelperez
fix: HoudiniGraphql#698 NPM packages exports and metadata
75d4bba
@romelperez romelperez mentioned this issue Nov 17, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NPM packages exports and metadata romelperez/houdini
2 participants
@AlecAivazis @romelperez