Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XML policy file validation feature to the AppControl Manager #495

Merged

Conversation

HotCakeX
Copy link
Owner

@HotCakeX HotCakeX commented Jan 3, 2025

Added policy validation feature to the AppControl Manager. It's a dedicated page where user can browse for App Control XML files and validate them. Useful if user modified an XML file manually and wants to make sure the modifications are valid according to the official schema.

AppControl Manager now has a page dedicated to validating App Control XML policy files to ensure they are compliant with the schema.
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 3, 2025
@HotCakeX HotCakeX self-assigned this Jan 3, 2025
@Copilot Copilot bot review requested due to automatic review settings January 3, 2025 09:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • AppControl Manager/AppControl Manager.csproj: Language not supported
  • AppControl Manager/MainWindow.xaml: Language not supported
  • AppControl Manager/Pages/ValidatePolicy.xaml: Language not supported
Comments suppressed due to low confidence (1)

AppControl Manager/Pages/ValidatePolicy.xaml.cs:53

  • The cast to boolean is unnecessary. The method TestCiPolicy should return a boolean directly.
isValid = (bool)CiPolicyTest.TestCiPolicy(selectedFile, null)!;
@HotCakeX HotCakeX changed the title Added policy validation feature to the AppControl Manager Added XML policy file validation feature to the AppControl Manager Jan 3, 2025
@HotCakeX HotCakeX merged commit 90ad8c2 into main Jan 3, 2025
2 checks passed
@HotCakeX HotCakeX deleted the Added-policy-validation-feature-to-the-AppControl-Manager branch January 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant