Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Keyboard ctrl-S or cmd-S is same as clicking Update button #665

Merged
merged 2 commits into from
Sep 24, 2016
Merged

Keyboard ctrl-S or cmd-S is same as clicking Update button #665

merged 2 commits into from
Sep 24, 2016

Conversation

amyrlam
Copy link
Contributor

@amyrlam amyrlam commented Sep 23, 2016 •
edited
Loading

Fixes part of #540.

  • Keyboard ctrl-S or cmd-S is same as clicking Update button, see gif
  • Overrides Chrome cmd-S keyboard shortcut
  • TODO: Next step would be to implement on all Update and Save buttons

keyboard gif

cc @HospitalRun/core-maintainers

Pair: @AlyChloe

jglovier
jglovier approved these changes Sep 24, 2016
View reviewed changes
Copy link
Member

@jglovier jglovier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, gang!! 🤘 ⚡

@jglovier jglovier merged commit 2d33113 into HospitalRun:master Sep 24, 2016
@amyrlam amyrlam mentioned this pull request Sep 27, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jglovier jglovier jglovier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyrlam @jglovier