Keyboard shortcut for Save

[mnorbeck]

Request is to provide keyboard shortcuts for Save. Ideally both Control-S and Command-S would be supported.

[danlourenco]

Does anyone have a problem with using an ember addon like ember-keyboard to accomplish this functionality? If not, I'd be happy to give this a stab.

[jglovier]

Does anyone have a problem with using an ember addon like ember-keyboard to accomplish this functionality?

@dlo83 I think that could be a great solution. @jkleinsc any objections to that?

[jkleinsc]

@jglovier and @dlo83 that is fine by me.

[danlourenco]

@jglovier, @jkleinsc : sweet, I'll take a crack at this.

[danlourenco]

FWIW: ember-keyboard doesn't yet support the command modifier key on Macs. Would a Ctrl+S shortcut suffice for the time being?

[jkleinsc]

@dlo83 wouldn't the command modifier be "OSRight" and "OSLeft"? I took a quick look at ember-keyboard and it appears this would work, but I didn't test it, so maybe there is a bug that I don't know about?

[danlourenco]

@jkleinsc one would think. However, I tried those command modifiers and was unable to trigger the update action with them. Ctrl+S worked as expected. The ember-keyboard repo explicitly states: Support for keyup, keydown, and keypress, as well as the modifier keys: ctrl, alt, shift, and meta. Perhaps the omission of command is intentional. I'll follow up with the developer of that repo.

EDIT: perhaps that's what meta was meant to do: adopted-ember-addons/ember-keyboard#38 . I'll continue looking into this.

[danlourenco]

@mnorbeck I think Ctrl+S/Cmd+S might be a problem here. It appears as though some browsers like Chrome don't allow you to override common keyboard shortcuts that are already registered in the browser (Ctrl+S, Ctrl+W, Ctrl+C, etc). Would you consider any alternatives? Perhaps adding an additional modifier key (Ctrl+Alt+S)?

[amyrlam]

I'll do this one with @AlyChloe

[amyrlam]

👋 Let's reopen this issue for tracking, I still need to add the keyboard shortcut to all Update or Save buttons. #665 implements the keyboard shortcut in one place.

[taras]

@amyrlam are you able to make a list of all of the places where this change needs to be applied?

Also, we have some mixins that are used across all edit screens.

Could we add this functionality as a mixin to one of those mixins?

[amyrlam]

@taras sure, sounds good, I'll take a look at that and reach out if questions

[jscottchapman]

@taras @amyrlam It looks like this one is in progress/being worked on. Is that right? Just wanted to make sure that someone didn't start working on the same issue unknowingly.

[amyrlam]

@jscottchapman I'm working on this one! I'll try to report back soon

[jkleinsc]

@amyrlam thanks for the update. I'm going to mark this item as in progress then.

[tangollama]

@amyrlam are you still interested in this issue? If not, I'll move it back to Help Wanted.

[amyrlam]

move it to help wanted, but i try to work on some hospital run again soon!

[tangollama]

Thx for the reply @amyrlam. Now worries. We're all volunteering. :)

[DerekTBrown]

@tangollama would love to take on this as well.

[tangollama]

Have at it. Thx.

…

On Nov 13, 2017, at 5:10 PM, Derek Brown ***@***.***> wrote: @tangollama would love to take on this as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.