-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Updating sortable columns to have sorting icon and updated cursor #558
Conversation
cc @HospitalRun/core-maintainers |
@pete-the-pete thanks for getting started on this! Only design feedback I have at the moment is we should probably reduce the size of the icons a bit, and instead of the double arrows, lets use a single triangle everywhere of this style. To differentiate between active filtering and non-active, lets take a queue from existing patterns and make the triangle color lighter on the non-active filters, and darker on active filters. |
If you'd like visual help beyond my written description above, I can post a design comp when I have some time in the next few days. |
I can take a look tomorrow and post an update. |
429dea8
to
8accc25
Compare
I updated to use the arrows and lighter color, but I am seeing this issue, stylelint/stylelint#1513 |
@pete-the-pete looks good to me. @jglovier what do you think: |
The new icons looks good, except I think we should only display the active arrow, and hide the others until you hover over it's associated column heading. |
@jglovier ping... what do you think? I would like to move this PR along. |
@jkleinsc, sorry, to be more clear I think by default we should always show an icon for the currently active sorted column. So there is always one sorting icon visible. Also, I'm not too concerned about discoverability because this is a feature most users will probably assume is there already. Sorting tabular data by column is more of an expected behavior than a novel feature we need to explicitly reveal. |
I am merging this PR as is. We can cleanup when the icons show as another issue. |
Fixes #328
Changes proposed in this pull request: