-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Need Indicator for Sortable Columns #328
Comments
👍 |
PS - we have Octicons included right now, so we should just use the arrow up/down from that set. |
Can you superimpose two icons together in octicons? I'm not seeing an icon usually used for "sortable" on that webpage. |
Swapping out the triangle up and the triangle down arrows on click would be appropriate. |
@jglovier we do swap up and down on click, but the issue is we don't show anything to indicate you can sort a column, so discoverability there isn't great. |
Right, so adding those octicons as indicators would resolve, right? Or am I missing something? |
Is this being actively worked on? If not, I'd like to look into it. We could show both https://octicons.github.com/icon/arrow-small-up/ and https://octicons.github.com/icon/arrow-small-down/ when a column isn't active, and then show only the up or down to indicate the sorted column. I think we should also change the cursor to pointer, so that it is obvious the column headings are clickable. |
@pete-the-pete @mongolianprincess was looking for an issue to start contributing and I had suggested this one. @mongolianprincess are you interested in taking this issue? If not @pete-the-pete it's yours. |
@pete-the-pete @mongolianprincess anyone working this? |
On the /inventory/listing page, there are a bunch of sortable columns to view the inventory and sort accordingly. However, prior to clicking on the column header, there is no indication that you can sort the column. Even on mouse over, the cursor is the text-selector and not the link-clicker.
I would recommend adding an icon like fa-sort as part of each sortable-column. Other sorting icons can be found here and searching with "sort" as the search phrase.
The text was updated successfully, but these errors were encountered: