Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Need Indicator for Sortable Columns #328

Closed
nerdkid93 opened this issue Mar 4, 2016 · 9 comments
Closed

Need Indicator for Sortable Columns #328

nerdkid93 opened this issue Mar 4, 2016 · 9 comments
Labels
in progress indicates that issue/pull request is currently being worked on

Comments

@nerdkid93
Copy link

On the /inventory/listing page, there are a bunch of sortable columns to view the inventory and sort accordingly. However, prior to clicking on the column header, there is no indication that you can sort the column. Even on mouse over, the cursor is the text-selector and not the link-clicker. Before sorting After sorting

I would recommend adding an icon like fa-sort as part of each sortable-column. Other sorting icons can be found here and searching with "sort" as the search phrase.

@jglovier
Copy link
Member

jglovier commented Mar 5, 2016

👍

@jglovier jglovier added design help wanted indicates that an issue is open for contributions labels Mar 5, 2016
@jglovier
Copy link
Member

jglovier commented Mar 5, 2016

PS - we have Octicons included right now, so we should just use the arrow up/down from that set.

@nerdkid93
Copy link
Author

Can you superimpose two icons together in octicons? I'm not seeing an icon usually used for "sortable" on that webpage.

@jglovier
Copy link
Member

jglovier commented Mar 7, 2016

Swapping out the triangle up and the triangle down arrows on click would be appropriate.

@jkleinsc
Copy link
Member

jkleinsc commented Mar 7, 2016

@jglovier we do swap up and down on click, but the issue is we don't show anything to indicate you can sort a column, so discoverability there isn't great.

@jglovier
Copy link
Member

jglovier commented Mar 8, 2016

@jglovier we do swap up and down on click, but the issue is we don't show anything to indicate you can sort a column, so discoverability there isn't great.

Right, so adding those octicons as indicators would resolve, right? Or am I missing something?

@pete-the-pete
Copy link
Contributor

Is this being actively worked on? If not, I'd like to look into it.

We could show both https://octicons.github.com/icon/arrow-small-up/ and https://octicons.github.com/icon/arrow-small-down/ when a column isn't active, and then show only the up or down to indicate the sorted column.

I think we should also change the cursor to pointer, so that it is obvious the column headings are clickable.

@jkleinsc
Copy link
Member

@pete-the-pete @mongolianprincess was looking for an issue to start contributing and I had suggested this one. @mongolianprincess are you interested in taking this issue? If not @pete-the-pete it's yours.

@tangollama tangollama added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 15, 2016
@tangollama
Copy link
Member

@pete-the-pete @mongolianprincess anyone working this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

No branches or pull requests

5 participants