This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
#322 Inconsistent Checkbox Spacings Fix #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLog entry and article entry added for assignment 1, will be moved to branch Assignment 1 before any pull requests are made, probably over the weekend.
|
@mvanstaalduinen thanks for the PR! @jglovier can you take a look at this PR? |
| @@ -10,7 +10,7 @@ | |||
| {{select-or-typeahead property="aisleLocation" label=(t 'inventory.labels.aisle_location') list=aisleLocationList selection=model.aisleLocation className="col-sm-5"}} | |||
| <div class="form-group col-sm-2"> | |||
| <label class="control-label">{{t 'inventory.labels.gift'}}</label> | |||
| {{em-checkbox label=(t 'inventory.labels.gift') property="giftInKind"}} | |||
There was a problem hiding this comment.
I think we should probably keep the label text on the element and 🔥 the label element on the line above because not having the text immediately beside the label makes it less clear what text the checkbox is associated with.
|
@mvanstaalduinen we're doing some PR maintenance. Are you planning on addressing the feedback @jglovier provided? Thanks for the update in advance. |
|
Closing due to lack of response. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 322.
Changes proposed in this pull request:
Removal of checkbox labels as proposed in issue #322 Inconsistent Checkbox Spacings.
Labels removed were Fulfill Request Label and Consume Label on Inventory New Request form.
Label also removed for Gift in Kind checkbox on Inventory Received form.
cc @HospitalRun/core-maintainers