Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Inconsistent Checkbox Spacings #322

Closed
nerdkid93 opened this issue Mar 1, 2016 · 9 comments
Closed

Inconsistent Checkbox Spacings #322

nerdkid93 opened this issue Mar 1, 2016 · 9 comments
Labels
help wanted indicates that an issue is open for contributions

Comments

@nerdkid93
Copy link

There are a couple of forms in inventory that use checkboxes, but they look out of place on the page with their labels. For example, on the "+ new request" page, the "fulfill" checkbox seems to have a lot more whitespace then the rest of the page. When it's selected, a new "consumed" checkbox appears that also looks out of place in terms of element padding. The labels for the checkboxes seem to be too far away from the checkboxes as well.

This seems like it could be solved by either removing the labels for checkboxes, by adjusting the checkbox row height to be only half the other rows' heights, or by removing the bottom margins for the checkbox labels.

Image of New Request Page

@tangollama
Copy link
Member

@jglovier, I see what's being referenced. Unless you disagree, I'm going to add this to the design list. Could we put this in "Help Wanted"?

@jglovier
Copy link
Member

jglovier commented Mar 3, 2016

Yeah, this def needs cleaned up. 👍 for help-wanted

@jglovier jglovier added design help wanted indicates that an issue is open for contributions labels Mar 3, 2016
@mvanstaalduinen
Copy link

Hello, I am an undergrad in computer science and MacEwan University in Edmonton. For one of my course we have to participate in an open source project and contribute to it in a few ways.

If no one has solved this issue I was wondering if I could take it on, @tangollama?

@tangollama
Copy link
Member

Swing away.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Mar 15, 2016, at 5:40 AM, mvanstaalduinen [email protected] wrote:

Hello, I am an undergrad in computer science and MacEwan University in Edmonton. For one of my course we have to participate in an open source project and contribute to it in a few ways.

If no one has solved this issue I was wondering if I could take it on, @tangollama?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#322 (comment)

@tangollama
Copy link
Member

Marketing as In Progress w/ @mvanstaalduinen working on this.

@tangollama tangollama added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 15, 2016
@jglovier
Copy link
Member

This seems like it could be solved by either removing the labels for checkboxes

👍 for solving by removing the labels for checkboxes.

@tangollama
Copy link
Member

@jglovier, I'm thinking this needs to move back to Help Wanted, yes?

@jglovier jglovier added the help wanted indicates that an issue is open for contributions label Jun 28, 2016
@jglovier
Copy link
Member

thinking this needs to move back to Help Wanted, yes?

@tangollama 👍 . Added back.

@tangollama tangollama removed the in progress indicates that issue/pull request is currently being worked on label Aug 6, 2016
@jscottchapman
Copy link
Contributor

This looks like a good one for my first contribution. I'm on it @tangollama. 🎯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted indicates that an issue is open for contributions
Projects
None yet
Development

No branches or pull requests

5 participants