Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

#1515: Update computed properties to avoid deprecated method #1519

Merged
merged 1 commit into from
Sep 25, 2018
Merged

#1515: Update computed properties to avoid deprecated method #1519

merged 1 commit into from
Sep 25, 2018

Conversation

FergusInLondon
Copy link
Contributor

@FergusInLondon FergusInLondon commented Sep 25, 2018

Fixes #1515

Description

To pre-empt the upcoming deprecation of fn().properties(...) for computed properties, all usages have been removed and replaced with the correct Ember.computed(..., fn()) method.

Tests

All tests pass on Solus Linux, using Node 6.14.4.

1..1603
# tests 1603
# pass  1603
# skip  0
# fail  0

# ok

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)

cc @HospitalRun/core-maintainers

@jsf-clabot
Copy link

jsf-clabot commented Sep 25, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@donaldwasserman donaldwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. Thanks for the help!

@donaldwasserman donaldwasserman merged commit 2d24fa9 into HospitalRun:master Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Computed Property .property() modifier
3 participants