Replace Computed Property .property() modifier

[donaldwasserman]

This is a long-lived Ember app, and has some some legacy ember code built in. One of these is the usage of the soon to be deprecated Ember computed property .property() modifier.

The usage in HR looks like this:

propertyName: function() {
  return thing
}.property('tracking_property')

this should be replaced with

import { computed } from '@ember/object';
//later....
propertyName: computed('tracking_property', function() {
  return thing
})

There are many instances of this across the app, so creating a codemod Example may be easier, but isn't required.

[FergusInLondon]

@tangollama - I can jump on this one today; it looks like a good one to get started on - and should expose me to some of the codebase and workflow.

[FergusInLondon]

List of references to .property() - gist

[donaldwasserman]

@FergusInLondon - Great! Thanks for the help!

[FergusInLondon]

I'll leave this here; it's the comment on the above referenced commit. (Github hasn't updated to reflect the fact that the first two notifications link to subsequently squashed commits - so should 404.)

Hoorah, all references to ...}.property(...) have been removed.

 2018-09-24 22:05:26 ⌚  archbox in ~/OpenSource/hospitalrun-frontend/app
± |issue/#1515-Fix-Computed-Properties ✓| → grep -r "property(" ./

 2018-09-24 22:05:34 ⌚  archbox in ~/OpenSource/hospitalrun-frontend/app
± |issue/#1515-Fix-Computed-Properties ✓| →

To Do Tomorrow

• Run through - module by module - updating any files that don't import computed(... fn()).
• Style check - some of the lines where functions require more properties have ended up quite lengthy.
• Consistent usage of parameters to the callback - i.e some have key, value at the moment, and some don't.
• Prepare Pull Request for Replace Computed Property .property() modifier  #1515 on the origin repository.