Fix divide by zero on Bucket Transform (apache#187)

HonahX · Dec 6, 2023 · 8b9bc1b · 8b9bc1b
1 parent a368bd9
commit 8b9bc1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pyiceberg/transforms.py b/pyiceberg/transforms.py
@@ -262,7 +262,7 @@ def hash_func(v: Any) -> int:
             raise ValueError(f"Unknown type {source}")
 
         if bucket:
-            return lambda v: (hash_func(v) & IntegerType.max) % self._num_buckets if v else None
+            return lambda v: (hash_func(v) & IntegerType.max) % self._num_buckets if v is not None else None
         return hash_func
 
     def __repr__(self) -> str:

diff --git a/tests/test_transforms.py b/tests/test_transforms.py
@@ -135,6 +135,7 @@ def test_bucket_hash_values(test_input: Any, test_type: PrimitiveType, expected:
 @pytest.mark.parametrize(
     "transform,value,expected",
     [
+        (BucketTransform(2).transform(IntegerType()), 0, 0),
         (BucketTransform(100).transform(IntegerType()), 34, 79),
         (BucketTransform(100).transform(LongType()), 34, 79),
         (BucketTransform(100).transform(DateType()), 17486, 26),