fix(bucket transform): bad comparison for truthy value #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jeez also noticed that the time transforms could use some love. I did some very similar work in a project involving time series data so will take a stab at making that more maintainable |
Fokko
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Looks good, thanks @jayceslesar for fixing this 🙌 Feel free to raise more PRs if you think it is an improvement :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bad comparison due to comparing the truthy value of arbitrary objects. This failed in the case where
vis equal to 0, as the truthy value of 0 isFalse.I have added a test that was failing before the change I made, and passes after the change was made.
Resolves #173