Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: backport M1 HVF patches to support recent Linux guests #96743

Closed
wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Contributor

@AkihiroSuda AkihiroSuda commented Mar 12, 2022

Update (Mar 14, 2022): The content of this PR was merged into QEMU 6.2.0_1: 0301a2b


Backport the following commits from QEMU master (QEMU 7):

These patches are required for running the following guests:

See https://gitlab.com/qemu-project/qemu/-/issues/899

Thanks to @fuzmish for testing: lima-vm/lima#712 (comment)

images.location default qemu patched qemu
impish/20220309*1
impish/20220204
impish/20220201
focal/20220308
focal/20220307
focal/20220302
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Backport the following commits from QEMU master (QEMU 7):
- qemu/qemu@ad99f64f hvf: arm: Use macros for sysreg shift/masking
- qemu/qemu@7f6c295c hvf: arm: Handle unknown ID registers as RES0

These patches are required for running the following guests:
- Linux 5.17
- Ubuntu 21.10, kernel 5.13.0-35.40  (March 2022)
- Ubuntu 20.04, kernel 5.4.0-103.117 (March 2022)

See https://gitlab.com/qemu-project/qemu/-/issues/899

Signed-off-by: Akihiro Suda <[email protected]>
@scalp42
Copy link
Contributor

scalp42 commented Mar 13, 2022

definitely needed 🙏

@SMillerDev
Copy link
Member

Those seem like serious problems. Is QEMU not going to release a fixed version for this?

@fuzmish
Copy link

fuzmish commented Mar 13, 2022

@SMillerDev According to their wiki, the next version, v7.0, is scheduled for release in mid-April. (Note: I am not a member/contributor of QEMU.)

2022-03-15 Hard feature freeze. Tag rc0
2022-03-22 Tag rc1
2022-03-29 Tag rc2
2022-04-05 Tag rc3
2022-04-12 Release; or tag rc4 if needed
2022-04-19 Release if we needed an rc4

If the homebrew project does not encourage manual patching, it may be acceptable to provide a version based on some RC tag.

@AkihiroSuda
Copy link
Contributor Author

If the homebrew project does not encourage manual patching, it may be acceptable to provide a version based on some RC tag.

Homebrew does not accept RC, IIUC
https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

@Bo98
Copy link
Member

Bo98 commented Mar 13, 2022

Given the patches will only be around for a month I'm provisionally ok with this (if another maintainer or two approves), but I'll probably open a PR rolling this and #96655 together rather than two revision bumps.

@SMillerDev SMillerDev mentioned this pull request Mar 13, 2022
4 tasks
baude added a commit to baude/homebrew-core that referenced this pull request Mar 13, 2022
Replaces Homebrew#96743 courtesy of AkihiroSuda

Signed-off-by: Brent Baude <[email protected]>
@carlocab
Copy link
Member

Will be merged in #96655.

@carlocab carlocab added do not merge rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR labels Mar 13, 2022
BrewTestBot pushed a commit that referenced this pull request Mar 13, 2022
Replaces #96743 courtesy of AkihiroSuda

Closes #96655.

Signed-off-by: Brent Baude <[email protected]>
Signed-off-by: Carlo Cabrera <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
@carlocab
Copy link
Member

Merged in 0301a2b.

@carlocab carlocab closed this Mar 14, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants