qemu: Add 9p support for darwin

[baude]

Qemu already has support for 9p in Linux. Adding this for MacOS users
will bring them into parity for 9p support.

This replaces Ashley's #95318

Signed-off-by: Brent Baude [email protected]

• [X ] Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• [X ] Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[baude]

@SMillerDev This replaces Ashley's PR. I am less experience to brew so appreciate the review.

[SMillerDev]

Could you run brew style --fix homebrew/core/qemu?

[baude]

I ran it but nothing in git appears to have changed. Is that expected?

[SMillerDev]

Are you working in a new clone of homebrew core?

[baude]

Are you working in a new clone of homebrew core?

@SMillerDev Yessir.

[SMillerDev]

Yeah, that's the issue then.

You can also point brew style --fix to the file I believe.

The general recommendation is to work in your live brew install.
https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#formulae-related-pull-request

[baude]

@SMillerDev So as a noob here, should I be doing what the docs recommend which is to get the patches to apply and then do a git diff on the source code and capture that as foo.diff? And then foo.diff would just be included versus downloaded?

[SMillerDev]

No, the downloaded option is definitely easier. Just change the file extension you're downloading.

[baude]

We good?

[cho-m]

Linux build failure:

../meson.build:1386:0: ERROR: Feature virtfs cannot be enabled: virtio-9p (virtfs) on Linux requires libcap-ng-devel and libattr-devel

Needs Linux-only dependencies within the on_linux do block. Maybe:

   on_linux do
+    depends_on "attr"
     depends_on "gcc"
     depends_on "gtk+3"
+    depends_on "libcap-ng"
   end

[carlocab]

We probably need to increment this formula's revision.

When making changes to this PR, please amend your existing commit instead of adding new ones. When you do so, change your commit message to

qemu: add 9p support for Darwin

(or similar) so that it conforms to the commit style guide.

[baude]

We probably need to increment this formula's revision.

I fixed up the other issues. Is incrementing something I do? If so, can you please elaborate?

[willcohen]

It'd just be adding revision 1 under the head line near the top, I think!

https://rubydoc.brew.sh/Formula#revision%3D-class_method

[willcohen]

Sorry for getting that wrong — GH is telling me that revision goes before head…

[baude]

What happened that two of the tasks were cancelled?

[trevor-viljoen]

LGTM

[SMillerDev]

Can you add the patches from #96743 too?

[baude]

I've added #96743 as asked ... I think the a maintainer needs to set the long ci timeout label?

[carlocab]

Thanks!

[BrewTestBot]

@carlocab has triggered a merge.

[saschasc]

Great to have 9p support soon!

I noticed that if I compile QEMU myself and run brew install spice-protocol beforehand, the clipboard sharing also works afterwards when compiling it from source. Would it be possible to add this to QEMU as well? Where would be the best place to request this? Who could help?