Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio 5.1.1 #73363

Closed
wants to merge 1 commit into from
Closed

platformio 5.1.1 #73363

wants to merge 1 commit into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Fixed a "The command line is too long" issue with a linking process on Windows (issue #3827)
  • Fixed an issue with device monitor when the "send_on_enter" filter didn't send EOL chars (issue #3787)
  • Fixed an issue with silent mode when unwanted data is printed to stdout (issue #3837)
  • Fixed an issue when code inspection fails with "Bad JSON" (issue #3790)
  • Fixed an issue with overriding user-specified debugging configuration information in VSCode (issue #3824)

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Mar 17, 2021
@ivankravets
Copy link
Contributor Author

@carlocab, are you sure we should remove the dependency which we need? PlatformIO fails.

@carlocab
Copy link
Member

carlocab commented Mar 17, 2021

The dependency is already provided by python-tabulate. Is this not exactly the same as the resource you were declaring?

❯ brew info python-tabulate
python-tabulate: stable 0.8.9 (bottled)
Pretty-print tabular data in Python
https://pypi.org/project/tabulate/

What errors are you getting? Can we update the test to catch this error?

@ivankravets
Copy link
Contributor Author

The tests are passed. Thanks!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants