abseil: update to build against c++17 #62803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
question: should I add this too ? depends_on macos: :high_sierra # needs C++17note: found using "c++17" grep on Formula directory |
SMillerDev
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Thanks @Mizux ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
|
🤖 A scheduled task has triggered a merge. |
This was referenced Oct 15, 2020
Closed
|
For the record: Fix for grpc in #62916 |
Mizux
added a commit
to or-tools/homebrew_or-tools
that referenced
this pull request
Oct 29, 2020
* Have been added to homebrew-core see: Homebrew/homebrew-core#62803
adamnovak
added a commit
to adamnovak/homebrew-core
that referenced
this pull request
Jun 6, 2023
This will fix Homebrew#133007 and undoes Homebrew#62803 since Abseil 20230125.3 shouldn't need it. I'd add a test for user code with C++17 and Abseil with C++14, but then I wouldn't be able to get rid of the fails with GCC 5 annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from PR #62790 with only the update of abseil.rb
note: To integrate or-tools I'll need a version of abseil compiled against c++17
details here: https://discourse.brew.sh/t/abseil-and-c-revision/8641