or-tools 8.0 (new formula) #62790
Closed
or-tools 8.0 (new formula) #62790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Oct 13, 2020
Mizux
force-pushed
the
ortools
branch
3 times, most recently
from
cbe25cf to
bc12cfd
Compare
|
@SMillerDev so this PR is currently blocked by abseil PR #62803 |
|
just rebased on top of master (2ae810e) -> abseil commit is not needed anymore... |
4 tasks
SMillerDev
reviewed
Oct 16, 2020
|
@SMillerDev your github patch should have remove one empty line too ^^;, so locally I fixit, rebase -i on master and fixup both patch... waiting for CI to finish since I'm on a Archlinux and I don't use homebrew (i.e. blind fix) |
dawidd6
reviewed
Oct 17, 2020
dawidd6
reviewed
Oct 17, 2020
dawidd6
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YES
YES
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?YES
brew test <formula>, where<formula>is the name of the formula you're submitting?YES
brew audit --strict <formula>(after doingbrew install <formula>)?YES
note: Have been tested here:
https://github.com/or-tools/homebrew_or-tools/actions/runs/303951348
note: Abseil commit is part of PR #62803, since we need it I rebased the ortools branch on top of abseil branch thus two commits...
Topic on abseil-cpp c++17
https://discourse.brew.sh/t/abseil-and-c-revision/8641