Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafkacat: enable support for deserializing Avro message #45739

Closed
wants to merge 2 commits into from

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Oct 23, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This required the addition of a new formula, libserdes, which is included in the first commit in this PR.

Add formula for libserdes, an Avro serialization/deserialization for
C/C++ with support for the Confluent Schema Registry.
This makes kafkacat useful for the most common Kafka deployments, which
use the Avro serialization format to encode the data in topics.
@fxcoudert
Copy link
Member

Duplicate of #44391

@fxcoudert fxcoudert marked this as a duplicate of #44391 Dec 27, 2019
@fxcoudert fxcoudert closed this Dec 27, 2019
@benesch
Copy link
Contributor Author

benesch commented Dec 27, 2019

Hmm, not quite, #44391 incorrectly lists librdkafka as a dependency of libserdes. I'll submit a PR to fix that up.

@benesch
Copy link
Contributor Author

benesch commented Dec 28, 2019

#48353

@peoplemerge
Copy link

peoplemerge commented Jan 15, 2020

@benesch I don't really grok the build process, but it doesn't seem like this has landed as a binary yet. You would hope it would after 2 weeks.
brew up && brew install kafkacat seems to be downloading a binary that lacks this improvement:
kafkacat --version 2>&1 |grep avro should display the avro improvements.

That said, brew install --build-from-source kafkacat works fine and has our patches. Ideas?

@benesch
Copy link
Contributor Author

benesch commented Jan 15, 2020

I think we need to add a revision 1 line to the kafkacat formula, or the bottles won't be rebuilt until a new version of kafkacat is added to Homebrew. I'm not positive, though. @fxcoudert can you advise?

@lock lock bot added the outdated PR was locked due to age label Feb 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants