serdes 5.3.1 (new formula), kafkacat (avro support)

[peoplemerge]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
  Improves kafkacat 1.5.0 #44261; implements kafkacat would benefit from avro support  #44390
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[peoplemerge]

I'm working through some dependency issues (it's my first time contributing here) running brew audit.

[BrewTestBot]

• Dependency 'curl' may be unnecessary as it is provided by macOS; try to build this formula without it.

[peoplemerge]

Should be ready to merge at this point

[peoplemerge]

@chenrui333 is a manual review required prior to merging?

[SMillerDev]

There is always a review prior to merging.

[peoplemerge]

@SMillerDev is there anything that I need to do to request a review? This has been ready to merge for a week.

The only question I had was how to set hashes for binary builds to include. Is this done by some magical post-merge build process or do I have to to some special incantation?

[SMillerDev]

No, you just have to wait until someone has time to look at it.

As for the bottles, those are updated when a maintainer pulls the changes.

[kinghuang]

@peoplemerge Any chance you can address the two review comments? I'm looking forward to Avro support in the kafkacat formula! :)

[peoplemerge]

@kinghuang so sorry! Life went boom. I'm back on it.

[peoplemerge]

Can someone kick the build? I can't see the build error, suspect it's test run fragility.

[SMillerDev]

@BrewTestBot test this please

[peoplemerge]

@SMillerDev bump... think this is ready for final review

[SMillerDev]

@BrewTestBot test this please

[SMillerDev]

Thanks @peoplemerge ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[fxcoudert]

@BrewTestBot test this please

[peoplemerge]

So - I gather this has merged (although I do see a message specifying unmerged commits).

When I pull master, it seems to still pour an old kafkacat bottle. The resulting kafkacat doesn't appear to have the updated avro options. Is there something still to do here?

Edit: however, the following works: brew install --build-from-source kafkacat

@SMillerDev - ideas?