Update bazel.rb to version 0.16.1 #31066
Conversation
ILZ has departed the project, so let's give him some well-deserved peace on the pings heh, just for future reference. |
| @@ -11,7 +11,9 @@ class Bazel < Formula | |||
| sha256 "4edb4d88f886980bc1933be3fe9f704bc48fc1663e74c3fadb49ce7333d4642a" => :el_capitan | |||
| end | |||
|
|
|||
| depends_on :java => "1.8" | |||
| depends_on "zip" => :build | |||
There was a problem hiding this comment.
I see from the previous PR these are only necessary on certain versions of macOS? We should scope them accordingly.
There was a problem hiding this comment.
In this case that would mean simply changing this line to:
depends_on "zip" => :build if MacOS.version <= :el_capitan
(if 10.11 and later are the platforms that need zip.)
| @@ -11,7 +11,9 @@ class Bazel < Formula | |||
| sha256 "4edb4d88f886980bc1933be3fe9f704bc48fc1663e74c3fadb49ce7333d4642a" => :el_capitan | |||
| end | |||
|
|
|||
| depends_on :java => "1.8" | |||
| depends_on "zip" => :build | |||
| depends_on "unzip" => :build | |||
There was a problem hiding this comment.
Could you scope this dependency the same way the zip dependency is scoped?
|
Hi, we have decided to from now on only ship Bazel with an embedded JDK. That is not compatible with Homebrews requirement of not shipping binaries. We thus have created our own TAP: https://groups.google.com/forum/#!topic/bazel-discuss/3Ht26sWhMuA So I was wondering what the best path forward for Bazel in homebrew core is? Thanks! |
PTAL @ilovezfs @JCount @keith
This patch release of Bazel also fixes a build error on homebrew that has been encountered with 0.16.0 #30653