Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 0.16.0 #30653

Closed
wants to merge 1 commit into from
Closed

bazel 0.16.0 #30653

wants to merge 1 commit into from

Conversation

JCount
Copy link
Contributor

@JCount JCount commented Jul 31, 2018

Created with brew bump-formula-pr.

@keith
Copy link
Contributor

keith commented Jul 31, 2018

@JCount looks like there's an issue here

@JCount
Copy link
Contributor Author

JCount commented Jul 31, 2018

Yup, I am looking at it in a VM.

@JCount JCount added 10.11 El Capitan is specifically affected build failure CI fails while building the software labels Jul 31, 2018
@keith
Copy link
Contributor

keith commented Aug 3, 2018

Did you figure out the root cause @JCount ? Any way I can help?

@JCount
Copy link
Contributor Author

JCount commented Aug 4, 2018

@keith I'd welcome any ideas about the build failure on 10.11. Is it a fundamental issue that means we should just set 10.12 as the minimum platform, and then just merge this PR?

(essentially anything useful is welcome in this PR 😉)

@philwo
Copy link
Contributor

philwo commented Aug 6, 2018

The failure looks like some minor problem that we could probably fix in Bazel (but from the error messages I'm not sure what causes it yet).

I'll setup a couple of Mac Pros for Bazel's CI with 10.11 and 10.12 and will see that we can get this fixed and then also continuously test Bazel on older versions of macOS.

If it turns out to be more difficult, I think we'd also be fine with bumping the minimum platform to 10.12.

@keith
Copy link
Contributor

keith commented Aug 6, 2018

Installing this formula directly now actually results in an error for me on 10.13.5:

ERROR: /private/tmp/bazel_gyrSHUHd/out/external/bazel_tools/third_party/zlib/BUILD:15:1: undeclared inclusion(s) in rule '@bazel_tools//third_party/zlib:zlib':
this rule is missing dependency declarations for the following files included by 'external/bazel_tools/third_party/zlib/compress.c':

buchgr added a commit to buchgr/homebrew-core that referenced this pull request Aug 9, 2018
There was a build failure for 0.16.0 (see Homebrew#30653). I want to test whether the current release candidate of 0.16.1 works before creating the final release.
@philwo
Copy link
Contributor

philwo commented Aug 10, 2018

@buchgr is working on a fix - basically we have to do three things:

  1. Add a patch to Bazel to workaround a compatibility issue with newer JDKs. (This will result in Bazel 0.16.1)
  2. Add a dependency on unzip / zip for this formula to workaround a too old version of these tools in macOS 10.11. (This resulted in the original build error seen here.)
  3. Slightly change the formular to build a version of Bazel without an embedded Azul Zulu OpenJDK (to conform with Homebrew's policy of not shipping binaries that haven't been built from source by the formula). For this, we also have to bump the Java requirement of this formular to Java 9 or higher, as Bazel can no longer (easily) run with Java 8.

@JCount
Copy link
Contributor Author

JCount commented Aug 10, 2018

@philwo Thanks for the update.

@JCount
Copy link
Contributor Author

JCount commented Aug 14, 2018

Closing this in favor of #31066.

@JCount JCount closed this Aug 14, 2018
@JCount JCount deleted the bazel-0.16.0 branch August 14, 2018 17:19
@lock lock bot added the outdated PR was locked due to age label Sep 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10.11 El Capitan is specifically affected build failure CI fails while building the software outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants