-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup: renamed from rustup-init #177840
rustup: renamed from rustup-init #177840
Conversation
maybe split the PR into two one depends_on rustup for test, one depends_on rustup |
What are you thinking? But the audit will fail if this isn't renamed all in one PR: $ brew audit rustfmt
rustfmt
* Can't find dependency 'rustup-int'.
Error: 1 problem in 1 formula detected. |
aha, that sounds about right. Yeah, the transition for such thing is not easy. |
also, this might need a long build label |
Gonna follow #165649 instead so this can be a syntax-only PR: add |
Shit. This breaks all my CIs. Such an important update without any warning and migration test.
|
Signed-off-by: Xavier Lau <[email protected]>
Signed-off-by: Xavier Lau <[email protected]>
Signed-off-by: Xavier Lau <[email protected]>
@AurevoirXavier this was tested and was expected to be backwards compatible. The only noticeable change is we now link can you share more about what exactly is breaking for you (i.e. a reproducible example)? EDIT: Looks like this is from |
I think there were already some links to this PR. Such as edgedb/edgedb#7590, hack-ink/AiR@3583c95. Please take a look. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?With #177582,
rustup-init
now provides the full rustup installation (so using therustup-init
installer is no longer necessary)Rename the formula to just
rustup
to reflect these changes (which also hopefully gives users some indication of these changes)