-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup-init: install proxy binaries #177582
Conversation
Ah but we need |
Ok moved proxy binaries to |
We could probably make one of them keg-only to fix the conflict. |
I do like that approach more since users could also rust:
rustup-init:
So I say we make |
We could manually link |
great idea, done! This looks pretty good to me now, my only other nit is I want to rename this to |
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Currently, this formula only contains a
rustup-init
binary (an installer) which a user must call once (and then will never need it again). It's not really useful in its current form because users can just docurl https://sh.rustup.rs | sh
to achieve the same.Instead, this actually installs all rustup-managed proxies (which are all just
rustup
symlinked under a different name). All users need to do is configure a default toolchain on the first run.The only downside is conflicting with
rust
, which was noted in the original PR #9617 but I think we should reconsider since it gives users the choice (and most users won't notice now that we have bottles and rust is only a build dep). It is also the same approach other packagers seem to have taken: arch, debian, nix